Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@fezfez
Copy link
Contributor

@fezfez fezfez commented Nov 3, 2023

No description provided.

Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @fezfez!

@Ocramius Ocramius self-assigned this Nov 5, 2023
@Ocramius Ocramius added this to the 3.12.0 milestone Nov 5, 2023
@Ocramius Ocramius changed the base branch from 3.11.x to 3.12.x November 5, 2023 13:08
@boesing
Copy link
Member

boesing commented Nov 6, 2023

Nice, thanks.
I'll revert the psalm bump and baseline changes as I'd like to address these "issues" by adding generics to those "*Options" classes.

Co-authored-by: Stéphane Demonchaux <[email protected]>
Signed-off-by: Stéphane Demonchaux <[email protected]>
Signed-off-by: Maximilian Bösing <[email protected]>
Copy link
Member

@boesing boesing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've reverted the psalm bump and applied some changes to the abstract pattern test to remove the dynamic property assertion.

@boesing boesing merged commit 66cf9a2 into laminas:3.12.x Nov 6, 2023
@boesing boesing changed the title Adds PHP 8.3 as new supported version Add support for PHP 8.3 Nov 6, 2023
@glo71317 glo71317 mentioned this pull request Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants