Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@rladdusaw
Copy link

@rladdusaw rladdusaw commented Sep 22, 2025

Resolves #57
Resolves #59

Bare minimum self-checks

What do you think of a person who only does the bare minimum?

  • I've updated this PR with the latest code from main
  • I've done a cursory QA pass of my code locally
  • I've ensured all automated status check and tests pass
  • I've connected this PR to an issue

Pieces of flare

  • I've written a unit or functional test for my code
  • I've updated relevant documentation it my code changes it
  • I've updated this repo's README if my code changes it
  • I've updated this repo's CHANGELOG with my change unless its a trivial change (like updating a typo in the docs)

Finally

If you have any issues or need help please join the #contributors channel in the Lando slack and someone will gladly help you out!

You can also check out the coder guide.

@netlify
Copy link

netlify bot commented Sep 22, 2025

Deploy Preview for lando-solr failed. Why did it fail? →

Name Link
🔨 Latest commit be84d6f
🔍 Latest deploy log https://app.netlify.com/projects/lando-solr/deploys/68d1b54f8c5c5f00085c2e49

@rladdusaw
Copy link
Author

rladdusaw commented Sep 22, 2025

@pirog, @reynoldsalec I'm unable to request a review through GitHub's UI, but I would appreciate it if you could take a look at my code and check the workflows.

@rladdusaw rladdusaw marked this pull request as draft September 23, 2025 14:46
@rladdusaw rladdusaw marked this pull request as ready for review September 24, 2025 15:08
@rladdusaw
Copy link
Author

Some of the checks are failing, but they appear to have been broken by a previous PR. I'm reopening the PR for review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support Solr 9.9 minor version Support 9.8 minor versions

1 participant