Remove the use of LazyLock in places where it's not necessary#546
Merged
dzhou121 merged 3 commits intolapce:mainfrom Aug 10, 2024
Merged
Remove the use of LazyLock in places where it's not necessary#546dzhou121 merged 3 commits intolapce:mainfrom
LazyLock in places where it's not necessary#546dzhou121 merged 3 commits intolapce:mainfrom
Conversation
This is a breaking change because it removes the (unused) implementation of `ExtEventHandler`, but this structure was only ever used in a private static and should not have been exposed as part of the public API (unless we make the EXT_EVENT_HANDLER public too)
Collaborator
|
The MSRV still needs to be bumped, since std |
Contributor
Author
|
LazyLock was already used before this PR in the renderer crate: floem/renderer/src/text/layout.rs Line 1 in 908c3f3 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mutex::newhas beenconston stable for a while so it can be used without the need forLazy.The use of
once_cell::Lazyhas also been replaced by the recently stabilizedstdversion, that is already used somewhere else so there is no MSRV bump.This PR also makes
ExtEventHandlerprivate (which is a breaking change), but this structure is only ever used in a private static and should not have been made public from the start (unless we also make the static public).