Summary

This pull request reverts to the 35.x.x branch of Electron. #12951 upgraded from Electron 35.5.1 to Electron 37.3.0. The primary reason for including this upgrade in Joplin v3.4 was probably to ensure that this security patch (also in Electron 35.6.0) was applied.

This pull request downgrades to Electron 35.7.5 and thus should still include electron/electron#47369.

Notes

Possible benefits of this pull request

• Consistency with pre-releases: The 3.4.x pre-releases have largely used Electron 35.x.x.
• Still includes chore: cherry-pick 2 changes from 1-M137 electron/electron#47369.
• May resolve an issue related to WSL (reported by @JGCarroll).
• Should resolve an orange titlebar issue on Windows.

Drawbacks

• Electron 35.x.x is near EOL.
• This pull request isn't as well tested as Desktop: Upgrade to Electron v37.3.0 #12951.
  • This may change in the near future.

Testing

Manual testing is currently in progress. Additional automated integration tests should run in CI (however, with a dev build of Joplin).

Plan: The following should be tested on each platform:

• Startup: The application starts in release mode
• Screen reader support: Verify that it's possible for the screen reader to interact with the note editor
• External editing
• Notifications
• Attaching files
• Printing
• Drag and drop

On Windows:

• Window appearance

The following should be tested on at least one platform:

• Secondary windows: Check that changes from one window are reflected in the others.
• Folder editor: Verify that it's possible to add an emoji to a folder.
• Tag editor: It's possible to associate tags with a note using the tag dropdown.
• Drawing tool: It's possible to insert and edit drawings.

Test results:

• Linux (Fedora 42/GNOME) (To-do)
  • (⚠️) Create a new task, set a notification for a few minutes in the future. Check whether the notification triggers.
    • Broken. See Notifications not working with Joplin 3.3.13 in Linux Mint & Cinnamon #12733 (comment).
  • Verify that the Joplin AppImage builds and can be started.
  • Open a note in a new window (Markdown editor). Verify that editing the note updates the main window.
  • Attach a PDF file using the "attach" button. Verify that it renders and can be printed to PDF from the note viewer.
  • Drag and drop an file from file explorer into the Rich Text editor in a new note. Repeat for the Markdown editor.
  • Create a new subnotebook using the right-click menu.
  • Open a note in an external editor. Make a change and save. Verify that the note updates based on the external change.
  • Verify that it's possible to add an emoji as a folder icon through right-click > edit.
  • Verify that clicking a resource link opens it in an external application.
    • Tested with a JSON file
  • Enable the Orca screen reader. Verify that Orca can read the note editor's content.
• Windows 11 (To-do)
• MacOS 15 (To-do)

Note: Post-merge, I have checked that the Windows and MacOS applications can be built, installed, and started.