Summary

Fixes #13009 by marking node-fetch as external from the main JS bundle. May also fix #13010.

Notes

• As per the discussion in Joplin v3.4.2 & later "Fail to fetch" error with Joplin server and self-signed certs #13009, bundling node-fetch with the main application seems to prevent the custom root CAs registered by vendor/syswide-cas.js from being used by shim.fetch. This pull request marks node-fetch as external to the main application bundle.
  • Application bundling was originally enabled in the Joplin v3.4.2 pre-release.

Testing

1. Start the Joplin 3.4.6 AppImage.
2. Configure WebDav synchronization with a server that uses a custom root CA.
3. Add a custom root CA file in settings > synchronization > advanced.
4. Verify that sync fails with "Fetch error: Failed to fetch".
5. Create a release build of Joplin.
6. Start Joplin and sync.
7. Verify that the "Fetch error: Failed to fetch" is no longer shown.
   • Note: I'm currently encountering a "PROPFIND : Access denied: Please check your username and password (401)" error. I suspect that this is due to a misconfigured WebDAV server in my VM.
8. Regression testing: Switch to a different profile, configure it to sync with Joplin Server on localhost, and verify that it can sync successfully.