Desktop: Fixes #13196: Fixed red close button not working on macOS 26 #13311
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
Contributor
Author
|
I have read the CLA Document and I hereby sign the CLA |
laurent22
reviewed
Sep 28, 2025
Comment on lines
69
to
76
| private updaterService_: AutoUpdaterService = null; | ||
| private customProtocolHandler_: CustomProtocolHandler = null; | ||
| private updatePollInterval_: ReturnType<typeof setTimeout>|null = null; | ||
| private updatePollInterval_: ReturnType<typeof setTimeout> | null = null; | ||
|
|
||
| private profileLocker_: FileLocker|null = null; | ||
| private ipcServer_: IpcServer|null = null; | ||
| private profileLocker_: FileLocker | null = null; | ||
| private ipcServer_: IpcServer | null = null; | ||
| private ipcStartPort_ = 2658; | ||
|
|
Owner
There was a problem hiding this comment.
Please remove all the white space changes
Contributor
Author
There was a problem hiding this comment.
Thanks, I’ve removed the whitespace changes. Please let me know if anything else needs adjustment.
0dc0fcc to
b1d3354
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
On macOS 26, the red close button did not close the main Joplin window.
Users had to force quit the app. This PR fixes the issue.
Fix
Testing
Demo
Before: Clicking the red close button did not close the window (macOS 26).
After: The window now hides correctly when the red close button is clicked.
Demo.mp4
Fixes #13196