-
Notifications
You must be signed in to change notification settings - Fork 162
Page/theme changer upgrade of Pr #1146 #1147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Page/theme changer upgrade of Pr #1146 #1147
Conversation
Signed-off-by: Shivansh Charak <[email protected]>
Signed-off-by: Shivansh Charak <[email protected]>
Signed-off-by: Shivansh Charak <[email protected]>
Signed-off-by: Shivansh Charak <[email protected]>
Signed-off-by: Shivansh Charak <[email protected]>
Signed-off-by: Shivansh Charak <[email protected]>
Signed-off-by: saurabhraghuvanshii <[email protected]>
|
upgrade of #1146 |
Signed-off-by: saurabhraghuvanshii <[email protected]>
|
The issue with this pr is
|
@ShivanshCharak I want to make change with your pr but I don't have write and this pr open with dicussion on slack, |
|
Well i cant see any conversation of creating this issue, in mesheryui channel, react 17 to 18 was not allowed as i mentioned in the conversation ranitmukerjee and i had regarding the commits, REACT REDUX was the issue to be REMOVED which u ADDED AGAIN ps adding few more components isnt doing major work, As i told in the pr i opened |
sorry but I don't have any intention, you can remove redux in new Pr |
|
No its okay, keep making irrelevant prs :) maybe copy some more code |
don't create issues everyone knows it is your hard work, I only made some minor changes, if I have write access I directly push changes to your branch, even I created Pr in your forked repo to merge you if you merge that pr all goods but after discussed I closed that one, it is open source here collaboration also works I think. |
|
Open source yes copy paste more code from other pr since you are the reviewer pass it too, |
already said I don't do it on intentions, chill man, your pr also gets merged even your 7 commits with my pr, so that means its yours changes and why would I do this by showing your commits if have to copy paste I will do it from strach without your commits |
|
unintionally added 2k lines same logic, same file names, even the variable name is same π |
its your work I only moved files to correct path and added one file only. it's your commits brother. sorry don't make it issue |
" yes , I copied the code" π u copied the code and messed up the last tab design |
Notes for Reviewers
Screencast.From.2025-08-22.23-37-44.mp4
This PR fixes #
Signed commits