Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@saurabhraghuvanshii
Copy link
Contributor

Notes for Reviewers

Screencast.From.2025-08-22.23-37-44.mp4

This PR fixes #

Signed commits

  • Yes, I signed my commits.

ShivanshCharak and others added 8 commits August 21, 2025 00:07
Signed-off-by: Shivansh Charak <[email protected]>
Signed-off-by: Shivansh Charak <[email protected]>
Signed-off-by: Shivansh Charak <[email protected]>
Signed-off-by: Shivansh Charak <[email protected]>
Signed-off-by: Shivansh Charak <[email protected]>
Signed-off-by: Shivansh Charak <[email protected]>
Signed-off-by: saurabhraghuvanshii <[email protected]>
@saurabhraghuvanshii
Copy link
Contributor Author

upgrade of #1146

Signed-off-by: saurabhraghuvanshii <[email protected]>
@leecalcote leecalcote merged commit d2e7ad0 into layer5io:master Aug 22, 2025
4 checks passed
@saurabhraghuvanshii saurabhraghuvanshii deleted the page/theme-changer branch August 22, 2025 19:32
@ShivanshCharak
Copy link
Contributor

ShivanshCharak commented Aug 22, 2025

The issue with this pr is

  • You cant make changes to package.json files
  • cant add tsconfig.json file
  • Copy pasted the majority of the code written in Page/theme changerΒ #1146 without the weird design at the end
  • Upgraded the version fro react 14 to react 17 and other update to the package.json
  • React redux removal was also the part of the pr -> too heavy

@saurabhraghuvanshii
Copy link
Contributor Author

The issue with this pr is

  • You cant make changes to package.json files
  • cant add tsconfig.json file
  • Copy pasted the majority of the code written in Page/theme changerΒ #1146 without the weird design at the end
  • Upgraded the version fro react 14 to react 17 and other update to the package.json
  • React redux removal was also the part of the pr -> too heavy

@ShivanshCharak I want to make change with your pr but I don't have write and this pr open with dicussion on slack,
and change of react is from 17 to 18 see properly because next 14 not supporting react 17 I think you know,
and your pr also merged so work is not waste it done properly. I forked your pr on running npm build it not working, there are major changes in this Pr. and I can make change with package.json if it is wanted.

@ShivanshCharak
Copy link
Contributor

ShivanshCharak commented Aug 22, 2025

Well i cant see any conversation of creating this issue, in mesheryui channel, react 17 to 18 was not allowed as i mentioned in the conversation ranitmukerjee and i had regarding the commits, REACT REDUX was the issue to be REMOVED which u ADDED AGAIN ps adding few more components isnt doing major work, As i told in the pr i opened Open for new changes i hope you understand what that means I can make change with package.json if i wanted i think while contributing to a pr u gotta stick with the issue scope which is not updating a package, i think it applied on everyone

@saurabhraghuvanshii
Copy link
Contributor Author

Well i cant see any conversation of creating this issue, in mesheryui channel, react 17 to 18 was not allowed as i mentioned in the conversation ranitmukerjee and i had regarding the commits, REACT REDUX was the issue to be REMOVED which u ADDED AGAIN ps adding few more components isnt doing major work, As i told in the pr i opened Open for new changes i hope you understand what that means

sorry but I don't have any intention, you can remove redux in new Pr

@ShivanshCharak
Copy link
Contributor

No its okay, keep making irrelevant prs :) maybe copy some more code

@saurabhraghuvanshii
Copy link
Contributor Author

No its okay, keep making irrelevant prs :) maybe copy some more code

don't create issues everyone knows it is your hard work, I only made some minor changes, if I have write access I directly push changes to your branch, even I created Pr in your forked repo to merge you if you merge that pr all goods but after discussed I closed that one, it is open source here collaboration also works I think.

@ShivanshCharak
Copy link
Contributor

Open source yes copy paste more code from other pr since you are the reviewer pass it too, minor changes 2k lines isnt minor
Comments are made for communication

@saurabhraghuvanshii
Copy link
Contributor Author

saurabhraghuvanshii commented Aug 22, 2025

Open source yes copy paste more code from other pr since you are the reviewer pass it too, minor changes 2k lines isnt minor Comments are made for communication

already said I don't do it on intentions, chill man, your pr also gets merged even your 7 commits with my pr, so that means its yours changes and why would I do this by showing your commits if have to copy paste I will do it from strach without your commits

@ShivanshCharak
Copy link
Contributor

unintionally added 2k lines same logic, same file names, even the variable name is same πŸš€

@saurabhraghuvanshii
Copy link
Contributor Author

saurabhraghuvanshii commented Aug 22, 2025

unintionally added 2k lines same logic, same file names, even the variable name is same πŸš€

its your work I only moved files to correct path and added one file only. it's your commits brother. sorry don't make it issue

@ShivanshCharak
Copy link
Contributor

ShivanshCharak commented Aug 22, 2025

there are major changes in this Pr

I only made some minor changes

its your work I only moved files to correct path

" yes , I copied the code" πŸš€ u copied the code and messed up the last tab design

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants