Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix(mobile): correct activity UI regressions #1937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
pete-watters wants to merge 7 commits into
base: dev
Choose a base branch
from
Draft

fix(mobile): correct activity UI regressions #1937

pete-watters wants to merge 7 commits into from

Conversation

@pete-watters
Copy link
Contributor

@pete-watters pete-watters commented Dec 18, 2025 •
edited
Loading

This PR:

  • fixes some regressions to mobile activity
  • adds some improvements to icons and the loading screen
  • fixes a type with the LD key releaseOnramperBuy -> release_onramper_buy

These issues were reported here

  1. The loading state momentarily shows the small (scrolled-up centered) title
  2. There aren't enough skeletons rows in the loading state
  3. The swap avatar is very obviously broken and misaligned
  4. The empty state layout broken (this one might've already been there)
  5. The cell structure overall doesn't match the design here: title shows the token name instead of Sent,Received, dates aren't in "distance from now" format
  6. Something funky happened with the avatars too, that affected Swaps asset selectors

@leather-bot
Copy link
Contributor

leather-bot commented Dec 18, 2025 •
edited
Loading

Leather Web Build 5a5da4b → https://pr-1937-leather-web.wallet-6d1.workers.dev

@leather-bot
Copy link
Contributor

leather-bot commented Dec 18, 2025 •
edited
Loading

Leather Extension build 5a5da4b — Extension build, Test report, Storybook, Chromatic

@codecov
Copy link

codecov bot commented Dec 18, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 0% with 349 lines in your changes missing coverage. Please review.
✅ Project coverage is 12.19%. Comparing base (100a85a) to head (5a5da4b).

Files with missing lines Patch % Lines
...tacks-transaction-item/stacks-transaction-icon.tsx 0.00% 35 Missing and 1 partial ⚠️
...pps/mobile/src/components/loading/loading-item.tsx 0.00% 35 Missing ⚠️
...src/features/activity/translate-activity-status.ts 0.00% 33 Missing ⚠️
...ed-transaction-list/submitted-transaction-icon.tsx 0.00% 29 Missing ⚠️
...extension/src/app/components/src20/src20-image.tsx 0.00% 23 Missing ⚠️
...mponents/account/account-avatar/account-avatar.tsx 0.00% 16 Missing ⚠️
...pps/mobile/src/features/activity/activity-item.tsx 0.00% 16 Missing ⚠️
...pps/extension/src/app/components/tx-asset-item.tsx 0.00% 12 Missing ⚠️
.../mobile/src/features/activity/activity-loading.tsx 0.00% 12 Missing ⚠️
...orm/form/sip10/sip10-token-send-form-container.tsx 0.00% 10 Missing ⚠️
... and 33 more
Additional details and impacted files 
@@            Coverage Diff             @@
##              dev    #1937      +/-   ##
==========================================
- Coverage   12.21%   12.19%   -0.02%     
==========================================
  Files        2298     2295       -3     
  Lines       92620    92710      +90     
  Branches     3775     3772       -3     
==========================================
  Hits        11310    11310              
- Misses      80347    80440      +93     
+ Partials      963      960       -3
Files with missing lines Coverage Δ
.../src/app/components/loaders/stx-balance-loader.tsx 0.00% <0.00%> (ø)
...rc/app/components/loaders/usdcx-balance-loader.tsx 0.00% <0.00%> (ø)
...c-deposit-status-item/sbtc-deposit-status-item.tsx 0.00% <0.00%> (ø)
...in/btc-crypto-asset-item/btc-crypto-asset-item.tsx 0.00% <0.00%> (ø)
...cks/stx-crypo-asset-item/stx-crypto-asset-item.tsx 0.00% <0.00%> (ø)
...llectibles/components/bitcoin/inscription-text.tsx 0.00% <0.00%> (ø)
...features/collectibles/components/bitcoin/stamp.tsx 0.00% <0.00%> (ø)
...collectibles/components/stacks/stacks-bns-name.tsx 0.00% <0.00%> (ø)
...s/components/stacks/stacks-non-fungible-tokens.tsx 0.00% <0.00%> (ø)
.../send-crypto-asset-form/form/stx/stx-send-form.tsx 0.00% <0.00%> (ø)
... and 33 more
Components Coverage Δ
bitcoin 61.46% <ø> (ø)
query 24.17% <ø> (ø)
utils 86.91% <ø> (ø)
crypto 65.97% <ø> (ø)
stacks 49.08% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pete-watters pete-watters force-pushed the chore/mobile-activity-fixes branch 2 times, most recently from b422cac to ab07eeb Compare December 19, 2025 11:44
@pete-watters pete-watters force-pushed the chore/mobile-activity-fixes branch 2 times, most recently from 334eb5f to 792c920 Compare December 19, 2025 12:22
pete-watters
pete-watters commented Dec 19, 2025
View reviewed changes
apps/mobile/src/features/activity/activity-loading.tsx

const estimatedRowHeight = 72;

export function ActivityLoading({ header, count }: ActivityLoadingProps) {
Copy link
Contributor Author

@pete-watters pete-watters Dec 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This improves the skeleton loader by filling the screen height with loaders

pete-watters
pete-watters commented Dec 19, 2025
View reviewed changes
apps/mobile/src/features/feature-flags/index.ts

export function useOnramperBuyFlag() {
return useBoolVariation('releaseOnramperBuy', false);
return useBoolVariation('release_onramper_buy', false);
Copy link
Contributor Author

@pete-watters pete-watters Dec 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes a mistake I had made when refactoring the web feature flags casing

pete-watters
pete-watters commented Dec 19, 2025
View reviewed changes
packages/ui/src/assets/icons/usdcx.svg
@@ -0,0 +1,5 @@
<svg width="320" height="320" viewBox="0 0 320 320" fill="none" xmlns="http://www.w3.org/2000/svg">
Copy link
Contributor Author

@pete-watters pete-watters Dec 19, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding this specifically as usdcx.svg so we can always show it correctly

pete-watters
pete-watters commented Dec 19, 2025
View reviewed changes
packages/ui/src/components/avatar/asset-avatar-icon.web.tsx
case 'nativeBtc':
return <BtcAvatarIcon indicator={indicator} size={size} {...rest} />;
case 'sip10': {
if ('contractId' in asset && 'imageCanonicalUri' in asset && 'name' in asset) {
Copy link
Contributor Author

@pete-watters pete-watters Dec 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding these assertions as it helps us decouple from '@leather.io/models'. That dependancy will disappear from the UI package entirely soon

pete-watters
pete-watters commented Dec 19, 2025
View reviewed changes
packages/ui/src/components/avatar/avatar.shared.ts
contractId,
name,
}: GetSip10AvatarImageProps) {
// TODO: work is needed to give better SIP-10 support often the imageCanonicalUri is not set
Copy link
Contributor Author

@pete-watters pete-watters Dec 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've uploaded a lot of SVGs to our image platform now so this work has been done

@pete-watters pete-watters force-pushed the chore/mobile-activity-fixes branch 2 times, most recently from 7a040ea to c6a2ba6 Compare December 19, 2025 13:52
@pete-watters pete-watters force-pushed the chore/mobile-activity-fixes branch from c6a2ba6 to 0b00582 Compare December 19, 2025 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pete-watters @leather-bot