enhance ngxtop ability #67
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
new file: ngxtop.egg-info/PKG-INFO new file: ngxtop.egg-info/SOURCES.txt new file: ngxtop.egg-info/dependency_links.txt new file: ngxtop.egg-info/entry_points.txt new file: ngxtop.egg-info/requires.txt new file: ngxtop.egg-info/top_level.txt modified: ngxtop/config_parser.py modified: ngxtop/ngxtop.py new file: tmp/ngxtop.log
modified: ngxtop/ngxtop.py
add ngxtop ability to support muti log_path and muti log_format
deleted: ngxtop.egg-info/SOURCES.txt deleted: ngxtop.egg-info/dependency_links.txt deleted: ngxtop.egg-info/entry_points.txt deleted: ngxtop.egg-info/requires.txt deleted: ngxtop.egg-info/top_level.txt
modified: ngxtop.py
delete some useless note
delete records[status] logging
| continue | ||
|
|
||
| format_name = 'combined' | ||
| access_logs_dict[path] = ['combined'] |
There was a problem hiding this comment.
I think here you lose all previously gathered format info for path
There was a problem hiding this comment.
you can see this line : log_formats_dict = dict(get_log_formats(config_str)) in function
detect_log_config . There did not lose all previously gathered format info for path
|
thanks @feigong, can you have some summary of this changes or break this down into smaller PR so it'd be easier for me to review and merge them? |
added 3 commits
August 6, 2016 11:02
modified: ngxtop/ngxtop.py
modified: ngxtop/ngxtop.py fix bug when type 'ngxtop info'
|
fix bug when tap commands like 'ngxtop' or 'ngxtop info' |
|
@lebinh OK ,I will think how to break these pr into smaller pr |
|
That'd be great! Thanks @feigong |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1 add ngxtop to handler multi log_path
2 add ngxtop ability to handler one log_path many log_formats