check remote mixin content type when downloading #283
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer's GuideImplement content-type checking for remote mixin downloads with contextual error wrapping and refresh IDE support documentation to align Neovim LSP setup for lets_ls on Neovim >= 0.11.2. Sequence diagram for remote mixin download with content-type validationsequenceDiagram
participant Config
participant RemoteMixin
participant HTTPServer
Config->>RemoteMixin: download()
RemoteMixin->>HTTPServer: GET mixin URL
HTTPServer-->>RemoteMixin: Response (with Content-Type)
RemoteMixin->>RemoteMixin: Check Content-Type
alt Content-Type allowed
RemoteMixin->>RemoteMixin: Read response body
RemoteMixin-->>Config: Return mixin data
else Content-Type not allowed
RemoteMixin-->>Config: Return error (unsupported content type)
end
Class diagram for RemoteMixin content-type validationclassDiagram
class RemoteMixin {
+download() error
}
class set.Set {
+Contains(string) bool
}
RemoteMixin --> set.Set : uses allowedContentTypes
Class diagram for improved error wrapping in Config.readMixinsclassDiagram
class Config {
+readMixins(mixins []*Mixin) error
}
class Mixin {
Remote RemoteMixin
}
Config --> Mixin : reads mixins
Mixin --> RemoteMixin : has Remote
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey there - I've reviewed your changes - here's some feedback:
- In mixin.go, Content-Type headers often include parameters (e.g. charset); consider parsing and normalizing the media type (using mime.ParseMediaType or stripping parameters) before checking against allowedContentTypes.
- Verify that the updated Neovim LSP config steps (vim.lsp.config.lets_ls and vim.lsp.enable("lets_ls")) align with the actual nvim-lspconfig API in 0.11.2 to avoid mismatches.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- In mixin.go, Content-Type headers often include parameters (e.g. charset); consider parsing and normalizing the media type (using mime.ParseMediaType or stripping parameters) before checking against allowedContentTypes.
- Verify that the updated Neovim LSP config steps (vim.lsp.config.lets_ls and vim.lsp.enable("lets_ls")) align with the actual nvim-lspconfig API in 0.11.2 to avoid mismatches.
## Individual Comments
### Comment 1
<location> `config/config/mixin.go:19-17` </location>
<code_context>
"github.com/lets-cli/lets/util"
)
+var allowedContentTypes = set.NewSet(
+ "text/plain",
+ "text/yaml",
+ "text/x-yaml",
+ "application/yaml",
+ "application/x-yaml",
+)
+
type Mixins []*Mixin
</code_context>
<issue_to_address>
**suggestion:** Consider normalizing Content-Type values for more robust matching.
Servers may include parameters like charset in the Content-Type header. Matching only the MIME type portion will help avoid false negatives.
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary by Sourcery
Enforce allowed content types for remote mixins and refine error reporting, while updating Neovim LSP configuration documentation
New Features:
Enhancements:
Documentation: