Added the option to filer emails in the query #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution, Daniël. I will review the changes ASAP. |
levz0r
requested changes
Aug 28, 2019
There was a problem hiding this comment.
Hey. First of all, it looks great! A few things needs to be done before merging though:
- Please update the code in examples/cypress/integration/gmail.spec.js to reflect your changes in README.md.
- In
gmail-tester.js, please format the spacing on lines 12, 24 and 28 and useconstinstead ofvar, also remove blank line on line 35. On lines 24 and 28 please use the name for the variable:before_epoch. In the future, I will add some eslint rules to make sure we all follow the same coding conventions.
Thanks again!
|
Hey, Sorry it took so long. I have made the changes you requested. I hope I did the spacing tight this time. |
|
Awesome! I've made some small modifications, and your PR is now merged! Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Thank you so much for adding the add feature. I was the one requested it and I have used it already.
The new code also gave me the pointers to adjust and expand the features.
I have added the option to filter the emails in the query. Now it is possible to just download the emails you need, so you do not need to have an extra function filtering the results afterwards. It is possible to select emails on sender, receiver and subject. Receiver is something I mostly added for myself, since I tend to use the feature of gmail a lot where you can add "+${string}" after your username to generate a unique email address.
I have also changed the way the init_query handles the dates, so it is possible to have more precise search parameters. By using epoch it is possible to define the cut-off moments on the second. This is useful if you want to run a test multiple times on one day or if you need to make sure emails arrive within a certain period after sending them.
Additionally I have updated the readme to reflect the changes I made. I have added a remark to make it clear how to define the date.
This is my first pull request, so please let me know if I made any mistakes.