Add support for fetching attachments #70
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
levz0r
reviewed
Nov 22, 2021
| } | ||
| } else { | ||
| let { parts } = gmail_email.payload; | ||
| const parts = [...gmail_email.payload.parts]; |
There was a problem hiding this comment.
Unfortunately, parts can't be const because there is an assignment to parts on line 77.
|
|
||
| if (options.include_attachments) { | ||
| const parts = gmail_email.payload.parts || []; | ||
| const attachmentInfos = parts.filter(part => part.body.size && part.body.attachmentId) |
There was a problem hiding this comment.
Can you please use underscore naming convention (e.g attachment_infos)?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an
include_attachmentsoption toget_messages. If set, anattachmentsfield is included in the returnedemailobject, containing an entry for each attachment, of the form{ data: string, filename: string, mimeType: string }. The data is left encoded as base64.