Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Comments

Bugfix for postgres host in GlobalConfig#43

Merged
shabani1 merged 1 commit intomainfrom
rs/bugfix-postgres-host
Jan 10, 2024
Merged

Bugfix for postgres host in GlobalConfig#43
shabani1 merged 1 commit intomainfrom
rs/bugfix-postgres-host

Conversation

@shabani1
Copy link
Contributor

What

  • Previously running alembic upgrade head without exporting POSTGRES_HOST=localhost would cause an error.
  • Can now run this command locally, and should no longer need to configure IDE or notebooks with a POSTGRES_HOST environment variable.

Why

POSTGRES_HOST was defaulting to db_postgres instead of localhost, which is the value set inside of docker.

Test plan

  • Run pytest sdk-python
  • Run examples/tests.ipynb and verify that there are no errors
  • Run examples/tutorial.ipynb and verify that the tutorial works as expected
  • Run examples/images.ipynb and verify that the tutorial works as expected

@shabani1 shabani1 merged commit 116ecc9 into main Jan 10, 2024
@shabani1 shabani1 deleted the rs/bugfix-postgres-host branch January 10, 2024 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant