.gitignore: Fix pkg/external-boot-image build #5212
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The build procedure for the package pkg/external-boot-image was changed recently and started to use Dockerfile.in to generate the final Dockerfile. Also, the tarball produced by this package is generated under the same package directory. This broke the pushing of the image because linuxkit will always mark the repository as dirty since it considers the Dockerfile and the tarball as changes in the sources. For instance, in the current state every time pkg/external-boot-image is built we got a dirty hash: lfedge/eve-external-boot-image:7e86027ed410a803a1c7d0c9f17dc98447f96c7f-dirty-c5eadef This can be easily fixed by just adding both Dockerfile and the generated tarball to .gitignore. Signed-off-by: Renê de Souza Pinto <[email protected]>
europaul
reviewed
Sep 9, 2025
| conf/device.key.pem | ||
| conf/soft_serial | ||
| pkg/kube/external-boot-image.tar | ||
| pkg/external-boot-image/build.yml |
Contributor
There was a problem hiding this comment.
and this file is not generated anymore?
OhmSpectator
approved these changes
Sep 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The build procedure for the package pkg/external-boot-image was changed recently and started to use Dockerfile.in to generate the final Dockerfile. Also, the tarball produced by this package is generated under the same package directory. This broke the pushing of the image because linuxkit will always mark the repository as dirty since it considers the Dockerfile and the tarball as changes in the sources. For instance, in the current state every time pkg/external-boot-image is built we got a dirty hash:
lfedge/eve-external-boot-image:7e86027ed410a803a1c7d0c9f17dc98447f96c7f-dirty-c5eadef
This can be easily fixed by just adding both Dockerfile and the generated tarball to .gitignore.
How to test and validate this PR
make pkg/external-boot-image)Changelog notes
None
PR Backports
No needs since the issue it's only on master.
Checklist
check them.