Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@OhmSpectator
Copy link
Member

Description

Backport of #5217

PR dependencies

None

How to test and validate this PR

See the original PR.

Changelog notes

Improve upgrade reliability. This prevents stale checkpoints that could lead to unnecessary downloads or unintended downgrade after a reboot (notably for upgrades initiated via Terraform provider 1.0.6).

Checklist

  • I've provided a proper description
  • I've added the proper documentation
  • I've tested my PR on amd64 device
  • I've tested my PR on arm64 device
  • I've written the test verification instructions
  • I've set the proper labels to this PR
  • I've added a reference link to the original PR
  • PR's title follows the template
  • I've checked the boxes above, or I've provided a good reason why I didn't
    check them.

When inhaleDeviceConfig returns skip (e.g. during BaseOS activation),
zedagent used to return early without saving the received config into
lastconfig. This left the on-disk checkpoint stale, so after reboot EVE
would reload the old config and recreate outdated BaseOS/ContentTree
objects. That could trigger spurious downloads and even unintended
downgrades on the next reboot.

Fix by persisting the received proto message also in the skip case,
ensuring lastconfig is always up to date.

Signed-off-by: Nikolay Martyanov <[email protected]>
(cherry picked from commit 2a0e01a)
@OhmSpectator
Copy link
Member Author

Yetus complains about zfs again =\

  Error: golangcilint: fatal error: libzfs.h: No such file or directory

@OhmSpectator OhmSpectator merged commit 7e78acc into lf-edge:14.5-stable Sep 15, 2025
41 of 42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants