encode: fix TimeTZ with second offsets #1039
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FYI this is failing CI so there's a bit of polish with this. @mjibson do you reckon you could help us with getting this merged at some point? Also, what's the process to have someone of the new team here to get permission to integrate changes in lib/pq? |
|
CI is failing due to a known goimports change on master - I don't think it's a real bug. |
lib/pq previously did not work with TimeTZ offsets with second offsets. Rectify this by modifying the parse format string as appropriate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lib/pq previously did not work with TimeTZ offsets with second offsets.
Rectify this by modifying the parse format string as appropriate.
Refs: #65066