avoid index out of range panic if string is shorter than we expect it #370
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can we also add a test case for this? |
|
Ultimately errorf(...) is going to panic anyways, so this PR doesn't really matter. The panic escaping out of pq is causing issues. Is there a reason pq should panic in this case instead of returning an error back to the code that called it? Perhaps there should be a panic recover in rows.Next(), instead of rewriting to pass the error all the way back up. https://github.com/lib/pq/blob/master/conn.go#L1406 I can submit another PR with the recover in it, if you agree. |
|
Does this line not cover it? |
|
It still passes the panic on runtime errors, which in our case was hit by an index out of bounds caused by expect. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.