Enhance Opt class with new transformation methods#24
Merged
trippwill merged 1 commit intorelease/v2.7from Jan 3, 2025
Merged
Conversation
Updated `Opt.cs` to add overloaded `AndThen` methods supporting nullable return types and introduced new `OrThen` methods for option handling. Added unit tests in `OptTests.cs` to validate the new functionality for both some and none cases.
There was a problem hiding this comment.
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
test/libanvl.Opt.Test/OptTests.cs:359
- Add a test for the
AndThenmethod withFunc<T, U?>andwhere U : structto ensure its behavior is covered.
[Fact]
Codecov ReportAttention: Patch coverage is
|
Test Results 3 files ± 0 3 suites ±0 0s ⏱️ ±0s Results for commit a05a55a. ± Comparison against base commit 03bad94. This pull request removes 1 and adds 6 tests. Note that renamed tests count towards both. |
trippwill
added a commit
that referenced
this pull request
Jan 3, 2025
Updated `Opt.cs` to add overloaded `AndThen` methods supporting nullable return types and introduced new `OrThen` methods for option handling. Added unit tests in `OptTests.cs` to validate the new functionality for both some and none cases.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated
Opt.csto add overloadedAndThenmethods supporting nullable return types and introduced newOrThenmethods for option handling. Added unit tests inOptTests.csto validate the new functionality for both some and none cases.