boost/filesystem: use version 4 for compatibility with std::filesystem #929
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey, Fabian, after some more research, I think I should update my recommendation here: gulrak/filesystem is std::filesystem-compatible (and header-only), sidestepping a lot of the pain we were getting in my other project from the API differences between boost::filesystem and std::filesystem. I'm guessing it'll save you a lot of API-divergence pain, too, as code continues to build on filesystem. What do you think? Some notes:
Cheers! P.S. Wish I'd steered us to this straight away when I saw someone had added the broken boost backport...sorry I just learned about it. |
cpsauer
added a commit
to hedronvision/bazel-make-cc-https-easy
that referenced
this pull request
Aug 1, 2023
…ystem_backport as std::filesystem fallback for Apple platforms. See also https://github.com/hedronvision/bazel-cc-filesystem-backport libcpr/cpr#929 (comment)
COM8
added a commit
that referenced
this pull request
Aug 1, 2023
boost/filesystem: use version 4 for compatibility with std::filesystem
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello again, @COM8,
I was messing around some more with similar backporting of std::filesystem with boost::filesystem in another project--and I was thinking: Might it make sense to move over to boost filesystem v4?
The advantage of using the newer api (rather than the older one, v3) is that it's more similar to std::filesystem, removing some potential future foot guns if we're just using it as a backport. (Docs.)
Thanks for being great!
Chris