-
Notifications
You must be signed in to change notification settings - Fork 1k
curl_container: allow calling GetContent without CurlHolder #1246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
04dda7c to
68044a4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for submitting this MR.
Are you aware that something like this would also wok:
parameters.GetContent(CurlHolder());(constructing a CurlHolder() is compatibly expensive)
|
For running clang-format there is: |
Wasn't aware of that - it feels a bit wrong to do as well but i can see how that would have been easier 😅 I'll get into the tests & docs :) |
|
Running the Can add the formatting of those into this MR but none of them should belong to my changes. |
This can be relevant when the parameters need to be passed to some different library (i.e. libmpv, gstreamer) and there is no cpr::Session to get a CurlHolder from. Signed-off-by: Sebastian Muxel <[email protected]>
Signed-off-by: Sebastian Muxel <[email protected]>
Signed-off-by: Sebastian Muxel <[email protected]>
7d93a48 to
8e86e81
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
This can be relevant when the parameters need to be passed to some different library (i.e. libmpv, gstreamer) and there is no cpr::Session to get a CurlHolder from.
I ran the clang-format script - it brought up issues but not with the file i touched. If there is a better way already implemented please let me know :)