Add LIBGIT2_VER_CHECK Macro for Version Comparison#6882
Merged
ethomson merged 3 commits intolibgit2:mainfrom Sep 30, 2024
Merged
Add LIBGIT2_VER_CHECK Macro for Version Comparison#6882ethomson merged 3 commits intolibgit2:mainfrom
ethomson merged 3 commits intolibgit2:mainfrom
Conversation
Member
|
I think that this is generally useful. I'd rather see our version number be human-parseable in a way that reflects the version number. For example: so that v1.8.2 is This also lets callers just say
which seems pretty readable to me. But I think that it's worth offering up a macro in case that's not very readable. But I think that I would put it as something that evaluates to truthy given a version number. For example: Then you'd use it as
|
For consistency, use LIBGIT2_VERSION_... as the constant name; deprecate LIBGIT2_VER_... names.
Member
|
Thanks! I updated based on my suggestions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This merge introduces a LIBGIT2_VERSION_CHECK macro in git2/version.h, similar to Qt's QT_VERSION_CHECK. The macro allows developers to compare the current version of libgit2 at compile time, making it easier to ensure compatibility with specific versions of the library.
Key Changes:
This enhancement will improve the ability to manage version-dependent code more efficiently. Please review the changes and provide feedback!