Colorspace names: add ProPhoto #4296
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0e4cfcb to
db4c287
Compare
sboukortt
previously approved these changes
Jun 17, 2025
Member
Author
|
Conformance is failing because the synthesized profiles no longer match (they get shorter names after this change). That's actually a bug in the conformance testing, it is too strict to expect synthesized profiles to have exact contents. This should fix that: libjxl/conformance#42 (please retry running the checks after the conformance testing has been fixed) |
Member
Author
|
For some reason, conformance is still failing for lossless_pfm but I cannot figure out what could be causing a change. If someone feels like figuring out, feel free! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See also #4270
This doesn't change jxlinfo output yet, but it does make synthesized ICC profiles have nicer names in the common cases (sRGB, Adobe98, ProPhoto, DisplayP3, Rec2100PQ, Rec2100HLG).
Also adds "ProPhoto" as a recognized keyword when specifying color spaces (e.g. in
cjxl,djxl,simplify_icc)