Avoid dllexport when built as static library on Win32 #4540
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `GenerateExportHeader` module assumes it's acting on a shared library. When libjxl is built as a static library, we must define `JXL*_STATIC_DEFINE` explicitly to disable symbol export. Without this, symbols from a statically built libjxl may be incorrectly exported as part of the ABI of any dynamic library that links against it. A CMake block attempting to handle this already existed, but it was a no-op because the internal objects had already been built.
kleisauke
added a commit
to libvips/build-win64-mxe
that referenced
this pull request
Dec 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
GenerateExportHeadermodule assumes it's acting on a shared library. When libjxl is built as a static library, we must defineJXL*_STATIC_DEFINEexplicitly to disable symbol export.Without this, symbols from a statically built libjxl may be incorrectly exported as part of the ABI of any dynamic library that links against it. See for example:
A CMake block attempting to handle this already existed, but it was a no-op because the internal objects had already been built.