Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add data source icons to the rest of the data source type pickers #182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 25, 2025
Merged

Add data source icons to the rest of the data source type pickers #182

merged 2 commits into from
Sep 25, 2025

Conversation

@mlanlazc
Copy link
Contributor

@mlanlazc mlanlazc commented Sep 24, 2025 •
edited
Loading

  • add icons to the rest of the pickers (add data source, edit data source, connect first data source)
  • use generic icon for "Sample Database"
image image image

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @mlanlazc, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the user interface by integrating data source icons into all relevant selection components, including those for adding, editing, and connecting data sources. This change aims to improve visual clarity and user experience by providing immediate visual cues for different data source types, with a specific generic icon for the 'Sample Database.'

Highlights

  • Enhanced UI with Data Source Icons: Implemented visual icons for data sources across all relevant pickers, including those for adding, editing, and connecting the first data source, improving user experience and clarity.
  • Generic Icon for Sample Database: Ensured that the 'Sample Database' entry consistently displays a generic database icon, providing a clear visual distinction.
  • Refactored Icon Retrieval Logic: Centralized the logic for retrieving data source icons into a new getDataSourceIcon utility function, making icon management more consistent and maintainable.
  • Updated Generic Database Icon: The generic database SVG icon (ic_database.svg) has been updated to a larger 16x16 size for better visual integration and consistency.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist bot reviewed Sep 24, 2025
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces icons for data sources across various pickers, which is a great UI improvement. The implementation involves a new helper function getDataSourceIcon to centralize icon logic. While the changes are mostly good, I've identified a few areas for improvement regarding potential bugs, code duplication, and type safety. Specifically, there's a potential for duplicate data source entries, a brittle logic for identifying the sample database, and some opportunities for refactoring in SelectDatabaseTypeOptions.tsx to improve maintainability and readability.

@mlanlazc mlanlazc merged commit 5724b72 into main Sep 25, 2025
5 checks passed
@mlanlazc mlanlazc deleted the milan/eng-1101/add-datasource-type-icons-for-the-rest-of-the-pickers branch September 25, 2025 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@skosijer skosijer skosijer approved these changes

@bears4barrett bears4barrett Awaiting requested review from bears4barrett

@kapicic kapicic Awaiting requested review from kapicic

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mlanlazc @skosijer