Derive path from seed #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…istic bip32 paths
jadwahab
reviewed
Jun 14, 2021
bip32/derivationpaths.go
Outdated
| // This is achieved by the following process: | ||
| // We split the seed bits into 3 sections: (b63-b32|b32-b1|b1-b0) | ||
| // Each section is then added onto 2^31 and concatenated together which will give us the final path. | ||
| func DerivePath(seed uint64) string { |
There was a problem hiding this comment.
can we rename seed to counter?
There was a problem hiding this comment.
I thought seed may have been more appropriate as it can be any number - we just happen to iterate a counter as part of our implementation.
jadwahab
approved these changes
Jun 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds new derivePath and deriveSeed methods, used to create deterministic bip32 paths.
This can be used to store an atomic counter in a persistent store and simply increment the counter when you need a new private key created. Pass the seed to DerivePath and will return a deterministic path by splitting the bits into 3 and joining them. This can then be reversed by calling DerivateSeed wherein you provide a path and the seed used is returned.