Adapted to New Libyui CMake Build Environment #40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is related to https://github.com/libyui/libyui/pull/178 :
We now longer ship a
FindLibyui.cmakewith libyui; we are trying to keep things simple. So this repo can now also no longer use it, but the change is really trivial: Just check if we have alibyui*.so.*(and by default it's in the usual$LIBDIR, i.e./usr/lib64).Since the CMake setup for this repo also uses other variables that a common
find_package()likeFindLibyui.cmakeuses, the necessary ones like the include dir are also explicitly set, even though it's just the standard/usr/include(since all headers are included asyui/YFoo.h).At the same time, the version is bumped to
4.0.0to be in sync with all the otherlibyui*packages (at least for now).