Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: line chart x-axis showing full dates instead of day numbers#18923

Closed
lightdash-bot wants to merge 1 commit intomainfrom
pete/pr-ff282407-49c6-4dd3-a790-cc57fc8ec52d-20251217194110
Closed

fix: line chart x-axis showing full dates instead of day numbers#18923
lightdash-bot wants to merge 1 commit intomainfrom
pete/pr-ff282407-49c6-4dd3-a790-cc57fc8ec52d-20251217194110

Conversation

@lightdash-bot
Copy link
Collaborator

@lightdash-bot lightdash-bot commented Dec 17, 2025

Changed the DAY time interval axis label formatter to return null instead of a custom formatter that only displayed day numbers. This allows echarts to use its default date formatting, which displays full dates (e.g., '12/09/2025' instead of just '9'). This aligns with industry-standard visualization tools and improves data clarity by providing complete temporal context on the x-axis.

Fixes: #18952

@github-actions
Copy link

Your preview environment pr-18923 has been deployed.

Preview environment endpoints are available at:

@github-actions
Copy link

Preview Environment

🌐 URL: https://lightdash-preview-pr-18923.lightdash.okteto.dev

📋 Logs: View in GCP Console

🔧 SSH: ./scripts/okteto-ssh.sh 18923

@torimwhaley torimwhaley marked this pull request as ready for review December 17, 2025 19:53
Copy link
Contributor

@stevelikesmusic stevelikesmusic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@torimwhaley how do we test this? Could you share a before/after screenshot to know how this affects the UI? I've tried testing in analytics and see the full date:

Screen Shot 2025-12-18 at 11.07.29 AM.png

But I'm probably using the wrong chart config for what you're after?

@torimwhaley
Copy link
Contributor

torimwhaley commented Dec 18, 2025

@stevelikesmusic I will show you what I mean! I can't access the preview anymore, I get a 503 error. Are you able to refresh the env?

Previously I reproduced the error, and it added really funky behavior when just looking at one day (showing the day hours for some reason). The tooltip shows the date correctly, but not the axis label (we would expect to see the full date on the axis "2025-11-13")

CleanShot 2025-12-18 at 07 48 08@2x CleanShot 2025-12-18 at 07 46 00@2x

Copy link
Contributor

The previews are fickle. They'll be up an hour or so and then get "put to sleep". They start up again when you click the Preview button. Really, the error message should say something about starting up the environment again rather than 503. It takes ~1 minute for everything to get running again.

Copy link
Contributor

I think I set up the same chart you shared in the preview and it still shows single digits for the days. Is this correct?

Screen Shot 2025-12-19 at 11.17.52 AM.png

@owlas owlas closed this Jan 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DAY time interval x-axis labels only display day numbers instead of full dates

4 participants