Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: allow toggling/untoggling custom tooltip#19484

Merged
joaoviana merged 1 commit intomainfrom
01-15-fix_allow_toggling_untoggling_custom_tooltip
Jan 16, 2026
Merged

fix: allow toggling/untoggling custom tooltip#19484
joaoviana merged 1 commit intomainfrom
01-15-fix_allow_toggling_untoggling_custom_tooltip

Conversation

@joaoviana
Copy link
Contributor

@joaoviana joaoviana commented Jan 15, 2026 •
edited
Loading

Closes: PROD-2511

Description:

Improved tooltip configuration behavior in chart visualization by:

  1. Adding immediate toggle response - when users turn tooltips on/off, the change happens instantly instead of waiting for debounce
  2. Preserving tooltip content when toggling off and back on
  3. Using refs to track previous state and current tooltip value
  4. Only applying debounced updates when actively typing in the tooltip editor

This creates a more responsive user experience while maintaining the debounce protection during active editing.

@joaoviana Graphite App
Copy link
Contributor Author

joaoviana commented Jan 15, 2026 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@joaoviana joaoviana mentioned this pull request Jan 15, 2026
Merged
@joaoviana joaoviana added 🖥 frontend This issue requires changes to the frontend 🐛 Bug Something isn't working as expected. This can be an error or an unexpected user experience labels Jan 15, 2026 — with Graphite App
@joaoviana joaoviana self-assigned this Jan 15, 2026
@joaoviana joaoviana requested a review from almeidabbm January 15, 2026 16:13
@joaoviana joaoviana marked this pull request as ready for review January 15, 2026 16:13
@joaoviana joaoviana force-pushed the 01-15-fix_allow_toggling_untoggling_custom_tooltip branch from 9d5cbe0 to 595cc92 Compare January 15, 2026 16:18
@joaoviana joaoviana force-pushed the 01-15-style_improve_custom_tooltip_ui_on_dark_light_mode branch from e8ddf02 to 6794a3b Compare January 15, 2026 16:18
@linear
Copy link

linear bot commented Jan 15, 2026

PROD-2511 Custom tooltip toggle does not fully disable custom tooltip display

@github-actions
Copy link

github-actions bot commented Jan 15, 2026

Your preview environment pr-19484 has been deployed.

Preview environment endpoints are available at:

@github-actions
Copy link

github-actions bot commented Jan 15, 2026 •
edited
Loading

Preview Environment

🌐 URL: https://lightdash-preview-pr-19484.lightdash.okteto.dev

📋 Logs: View in GCP Console

🔧 SSH: ./scripts/okteto-ssh.sh 19484

almeidabbm
almeidabbm approved these changes Jan 15, 2026
View reviewed changes
Copy link
Contributor

@almeidabbm almeidabbm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful!!!

Before

Image

After

Image

@joaoviana joaoviana force-pushed the 01-15-fix_allow_toggling_untoggling_custom_tooltip branch from 595cc92 to cf43c42 Compare January 16, 2026 09:29
@joaoviana joaoviana force-pushed the 01-15-style_improve_custom_tooltip_ui_on_dark_light_mode branch from 6794a3b to aa261c5 Compare January 16, 2026 09:29
@joaoviana joaoviana changed the base branch from 01-15-style_improve_custom_tooltip_ui_on_dark_light_mode to graphite-base/19484 January 16, 2026 12:09
@joaoviana joaoviana force-pushed the 01-15-fix_allow_toggling_untoggling_custom_tooltip branch from cf43c42 to 3c8f4f3 Compare January 16, 2026 12:09
@joaoviana joaoviana force-pushed the graphite-base/19484 branch from aa261c5 to 5b0da2c Compare January 16, 2026 12:09
@graphite-app graphite-app bot changed the base branch from graphite-base/19484 to main January 16, 2026 12:10
@joaoviana joaoviana force-pushed the 01-15-fix_allow_toggling_untoggling_custom_tooltip branch from 3c8f4f3 to 269dabe Compare January 16, 2026 12:10
@joaoviana joaoviana merged commit 6cbbf9e into main Jan 16, 2026
2 of 3 checks passed
@joaoviana Graphite App
Copy link
Contributor Author

joaoviana commented Jan 16, 2026

Merge activity

@joaoviana joaoviana deleted the 01-15-fix_allow_toggling_untoggling_custom_tooltip branch January 16, 2026 12:10
lightdash-bot pushed a commit that referenced this pull request Jan 16, 2026
@semantic-release-bot
chore(release): 0.2347.1
01109b8 
## [0.2347.1](0.2347.0...0.2347.1) (2026-01-16)

### Bug Fixes

* allow toggling/untoggling custom tooltip ([#19484](#19484)) ([6cbbf9e](6cbbf9e))
* improve content-as-code validation ([#19375](#19375)) ([257b22d](257b22d))
@lightdash-bot
Copy link
Collaborator

lightdash-bot commented Jan 16, 2026

🎉 This PR is included in version 0.2347.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@graphite-app graphite-app[bot] graphite-app[bot] left review comments

@almeidabbm almeidabbm almeidabbm approved these changes

Assignees

@joaoviana joaoviana

Labels

🐛 Bug Something isn't working as expected. This can be an error or an unexpected user experience 🖥 frontend This issue requires changes to the frontend released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@joaoviana @lightdash-bot @almeidabbm