move NextQueueItemIsValid check to properly account for swap (genshin…

…sim#1993)

fix infinite recursion err following charge err refactor (genshinsim#…

…1990)

add NextQueueItemIsValid to Character Interface (genshinsim#1988)

- refactor error if using charge without attack

add error if using charge without attack beforehand (genshinsim#1987)

- all sword users except furina
- all polearm users
- 2 catalyst users: heizou, wriothesley
- 1 bow user: tartaglia

add aim hold params for all bow characters (genshinsim#1980)

- fix tartaglia aim aoe docs
- adjust tartaglia aimedFrames init
- add amber aim hold param
- add aloy aim hold param
- add diona aim hold param
- add fischl aim hold param
  - fix fullaim missing lv. 12-15
- add ganyu aim hold param
- add gorou aim hold param
- add sara aim hold param
- add venti aim hold param
- add yelan aim hold param
- add yoimiya aim hold param
  - breaking change: kindling param removed (only 1 db sim affected so not that bad)
- add collei aim hold param
- add faruzan aim hold param
  - fix non-a1 hurricane arrow not triggering pressurized collapse
- add lyney aim hold param
  - breaking change: level param removed (0 db sims affected so not that bad)
- add tighnari aim hold param
  - breaking change: level param removed (2 db sims affected so not that bad)

fix dehya (genshinsim#1900)

visible changes:
- attack:
  - **fix normal attacks resetting the boolean for whether skill had been reused**
  - **fix dehya n1 to n4 and reposition lv.4 multipliers**
  - fix dehya n1 to n4 hitlag and small attack hitmark/action frame adjustments
- skill:
  - **implement skill damage mitigation and self DoT**
  - **fix skill cast/recast frames**
  - **fix skill damage DoT having icd (should have no icd)**
  - **fix field proc delay (10f -> 2f after dmg)**
  - **fix field proc hitlag not being deployable**
  - **fix field triggering on final burst hit damage**
  - **fix burst casting skill if starting with skill off cooldown**
  - **fix redeployed field not using saved DoT damage cooldown**
  - fix sac field pickup timing to happen right before redeploy instead of on action start
- burst:
  - **add dash -> jump interaction during burst leading to kick**
  - **fix first punch, kick, slow punch frames**
  - **fix burst interaction with attack/skill/jump during punches**
  - fix burst not being hitlag extendable (doesn't really matter right now because burst punch/kick do not have hitlag)
  - fix punch/kick state for iframe semantics 
  - min 6 punches idle, max 10 punches <C6, max 15 punches C6 applies now
- ascension:
  - **implement a1**
  - **implement a4**
- constellations:
  - **implement c2 dmg buff**
  - **fix c2 not extending field correctly**
  - **fix c2 extending initial cast**
  - fix c4 icd not being hitlag extended
  - adjust c2 flag reset to be a bit more future-proof

dev related changes:
- add new function to remove field since it is used in several scenarios
- skill recast function now uses character skill tracking variable for skill duration
- rename boolean for skill reuse to make more sense 
- rename remove field to pick up field
- move asc/cons checks into the functions
- move c2 to its own event sub
- remove old burst cast tracking variable
- remove old burstCast tracking variable
- replace burstFrames with constant
- refactor jump canceling burst punches
- refactor dehya c1, c2, c4, c6
- cannot cancel before first punch so simplified burst func
- remove unnecessary hitlag info for non-hitlag attacks in skill

---------

Co-authored-by: k0l11 <[email protected]>

add AimParam type and tartaglia aim hold param (genshinsim#1959)

AimParam:
- 0 = phys
- 1...4 different aimed shot levels (see code comments)
- no ARCC support intended

tartaglia:
- hold = 0: phys
- hold = 1: fully-charged (default)
- fix ca riptide behaviour based on e state before hit:
 - phys, e state not active: no riptide related trigger
 - phys, e state active: apply riptide -> slash
 - fully-charged, e state not active: only apply riptide
 - fully-charged, e state active: apply riptide -> slash
 - fully-charged will not trigger flash if riptide does not exist beforehand

adjust damage timeline legend to fill remaining space (genshinsim#1946)

- previously was towards top left of card instead of center of remaining space at top

fix localization for all supported languages in most places (genshins…

…im#1939)

- best effort (probably has akward wording/inconsistency in terminology use, tried my best)
- add back german localization
- fix db lang select to have same items as web
- remove most unused translation keys (some still left in there...)
- localization exceptions: stats like hp, db README, db description, upgrade dialog metadata prop names like version, errors, ...

adjust wriothesley c2 to explicitly check for a4 (genshinsim#1933)

- so that +0 dmg% doesn't get logged
- no difference in behaviour to previous fix