Integrate tests with ctest #126
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alfred Wingate <[email protected]>
Signed-off-by: Alfred Wingate <[email protected]>
Otherwise the tests aren't very discoverable. Signed-off-by: Alfred Wingate <[email protected]>
Signed-off-by: Alfred Wingate <[email protected]>
Signed-off-by: Alfred Wingate <[email protected]>
Signed-off-by: Alfred Wingate <[email protected]>
|
This corrects many ugly decisions i've made, thanks! As for the hidden tests: I did that to debug some problem very early on and then somehow carried it through all the way. Will remember not to do that for future tests. |
|
It took me too long to realise that they were been hidden :D Also for the xfails, I presume some of them will pass for you (atleast one of them was a missing data file). You should look into removing them, its either that they were broken already or its something on my system leading to a failure. So I'd be interested in seeing if there are real failures on my end. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fact that all the tests were hidden with the tags skill checked me hard. For testing it would be more useful if all or most tests were in the default list so that people would run tests. Otherwise its very easy to miss.
Added failing tests to xfail, atleast one of them appears to fail due to missing data files.
Reuse core object for tests and application.
Include tests in root CMakeLists.txt with standard cmake BUILD_TESTING option controlling whether its built or not..
https://cmake.org/cmake/help/git-stage/variable/BUILD_TESTING.html