Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Prepare the changelog for 0.6.0. #1006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
xStrom merged 1 commit into from
Jun 1, 2020
Merged

Prepare the changelog for 0.6.0. #1006

xStrom merged 1 commit into from
Jun 1, 2020

Conversation

@xStrom
Copy link
Member

@xStrom xStrom commented Jun 1, 2020

I cleaned up the changelog in preparation for release.

  • Given how much the context method availability changed, I combined all those changes under a single entry.
  • I moved all X11 related entries under the highlight, because this is an unreleased feature and so specific fixes aren't that relevant to developers.
  • I added a new Examples section, because we have a few of those and they don't quite fit under Docs.
  • I reordered some of the entries for better readibility, grouping entries by their first word and/or theme.

@xStrom xStrom added docs concerns documentation S-needs-review waits for review labels Jun 1, 2020
luleyleo
luleyleo reviewed Jun 1, 2020
View reviewed changes
Copy link
Collaborator

@luleyleo luleyleo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
Maybe add a link to the latest release at the top, because the Unreleased section is already longer than my screen even though it's still empty.

CHANGELOG.md Outdated
Comment on lines 95 to 76
- `scale` method to `WinHandler`. ([#904] by [@xStrom])
- `WinHandler::scale` method to inform of scale changes. ([#904] by [@xStrom])
Copy link
Collaborator

@luleyleo luleyleo Jun 1, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those seem to be the same.

Copy link
Member Author

@xStrom xStrom Jun 1, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Some sort of rebase failure of the original PR I guess. I can't even see where the shorter line exactly got added.

@luleyleo luleyleo added S-waiting-on-author waits for changes from the submitter and removed S-needs-review waits for review labels Jun 1, 2020
@xStrom xStrom added S-needs-review waits for review and removed S-waiting-on-author waits for changes from the submitter labels Jun 1, 2020
@xStrom
Copy link
Member Author

xStrom commented Jun 1, 2020

I improved the above-the-fold experience.

luleyleo
luleyleo approved these changes Jun 1, 2020
View reviewed changes
Copy link
Collaborator

@luleyleo luleyleo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! I'm happy with this 👍

@xStrom xStrom force-pushed the changelog-0.6.0 branch from 778958e to c84e52b Compare June 1, 2020 15:19
@xStrom xStrom merged commit bb0ec36 into linebender:master Jun 1, 2020
@xStrom xStrom deleted the changelog-0.6.0 branch June 1, 2020 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@luleyleo luleyleo luleyleo approved these changes

Assignees

No one assigned

Labels

docs concerns documentation S-needs-review waits for review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@xStrom @luleyleo