Bring poly-cool into the kurbo repo #502

jneem · 2025-09-06T02:34:48Z

As discussed in the last office hours, this PR brings the poly-cool crate into the kurbo repo in preparation for making it a kurbo dependency. This is almost a copy of the last poly-cool release version, except that I deleted some of the #[doc(hidden)] experiments.

I bumped the MSRV to 1.85 because that's poly-cool's MSRV and I think it makes sense just to have one (plus, that's how the CI is set up).
Do we have a process for managing changelogs in a multi-crate repo? I looked in linebender/xilem for an example, but I couldn't find a changelog...
What's the crates.io process? I tried adding github:org:linebender as an owner but crates.io didn't like it. Should I just add the kurbo owners individually?

dfrg · 2025-09-08T17:11:47Z

I bumped the MSRV to 1.85 because that's poly-cool's MSRV and I think it makes sense just to have one (plus, that's how the CI is set up).

Is this an absolute requirement or just a nice-to-have?

jneem · 2025-09-08T18:28:57Z

Not an absolute requirement, but it brings edition 2024 and a couple of f64 methods in core (which mean a little less polyfilling when building with no_std)

polycool/LICENSE-MIT

tomcur

This is really cool.

What's the crates.io process? I tried adding github:org:linebender as an owner but crates.io didn't like it. Should I just add the kurbo owners individually?

I believe the policy is that there are at least two crate owners.

poly-cool/Cargo.toml

Co-authored-by: Tom Churchman <[email protected]>

DJMcNab · 2025-09-11T14:31:22Z

poly-cool/Cargo.toml

@@ -0,0 +1,44 @@
+[package]
+name = "poly-cool"


It's a shame that this crate name is hyphenated, but obviously there's nothing to be done about that...

I could change it to polycool. Or something else, I'm not that attached to the name...

Well, what I mean is that poly-cool is already on crates.io under that name, which I didn't think we were proposing to not happen

Right, and the existence of poly-cool on crates.io means that I can't rename to poly_cool. But I could rename to polycool if we really want to avoid hyphenated names. A rename would be pretty painless at this early point.

xStrom · 2025-09-11T15:35:22Z

Do we have a process for managing changelogs in a multi-crate repo? I looked in linebender/xilem for an example, but I couldn't find a changelog...

No documented process for cases where the version numbers diverge between the crates. That said, I think the move is for poly-cool to just have its own CHANGELOG.md in its own directory.

DJMcNab

I don't really have the context to review this as a library, but just some of the license details.

I do realise that the back-and-forth here is a massive pain.

poly-cool/LICENSE-MIT

polycool/Cargo.toml

DJMcNab

Latest version of the licensing looks good. Sorry I don't have the context to actually review this code.

Thanks for not trying to migrate Kurbo to it in this PR!

jneem · 2025-09-12T13:29:16Z

That said, I think the move is for poly-cool to just have its own CHANGELOG.md in its own directory.

Any objection to moving the workspace-wide CHANGELOG into kurbo/ then? That way I can add one to poly-cool and it will look nice and symmetric.

polycool/src/poly_dyn.rs

tomcur

This is very useful, and though I've only coarsely checked the implementation (I don't currently have the time to dive into the background or the nitty-gritty math), the things I did check make sense. I'd be happy just approving it.

tomcur · 2025-09-15T21:59:49Z

poly-cool/src/poly.rs

+    /// Returns the largest absolute value of any coefficient.
+    ///
+    /// Always returns a non-negative number, or NaN if some coefficient is NaN.
+    pub fn magnitude(&self) -> f64 {


I've heard this called a "coefficient norm" instead (of which there are others...). I'm not sure whether there's fully standard terminology here. Perhaps for clarity we'd want to call this coefficient_magnitude or something (perhaps even with max_ prefix).

If we're going more explicit, how do you feel about max_abs_coefficient? I think "abs" in this context is more widely used than "magnitude"

polycool/src/poly_dyn.rs

poly-cool/src/cubic.rs

dominikh

IMHO this is good enough to merge and iterate on.

jneem · 2025-09-24T01:35:53Z

At office hours last week, the conclusion was that the kurbo changelog can stay at the top level, and poly-cool can have one in its subdirectory. I think that leaves the following questions:

How big of a deal is the MSRV bump? (@dfrg)
The hyphenated name is inconsistent with other linebender crates. Should we rename to fix it?

DJMcNab · 2025-09-24T08:23:20Z

The MSRV bump is fine; our 0.12 release was very recent, and 1.85 is already 6 months and 5 Rust releases old.

From my perspective, it's fine to keep the hyphenated name for legacy reasons. That is, having two crates of identical names with the same functionality and publishers is not a good solution. And I think I'm the only one who has expressed against it.

I agree with just landing this, and iterating once it's in tree.

nicoburns · 2025-09-24T17:29:47Z

I would be in favour of renaming to remove the hyphen on the basis that "molecule" and "polycule" are both one word in english and also that typing module names without hyphens/underscores is easier. As long as the old crate points to the new one, I don't see any major problems with that.

jneem · 2025-10-18T21:57:46Z

Ok, I was convinced to go with polycool. It's an easy thing to change now, and would be more difficult later. I've re-published the latest poly-cool release as polycool on crates.io, and Tom and Chad have accepted ownership (I picked them because they were the first two to comment on this PR. If anyone else wants it, let me know.)

This incorporates the fixes and changes made during the review of #502. It's a breaking change because of the `magnitude` -> `max_abs_coefficient` rename. Since polycool is versioned independently of kurbo, we need a release-tagging scheme that won't clash. I suggest `v0.4.0-polycool` (TODO: update the date before merging)

jneem added 6 commits September 5, 2025 21:14

Bring poly-cool into the kurbo repo

58134c5

Add copyright headers

fb4f33c

Add keywords

fc0cf04

Add categories

de34821

Remove rayon from criterion

b850f17

Mark arbitrary as depending on std

ff1e45d

tomcur reviewed Sep 8, 2025

View reviewed changes

polycool/LICENSE-MIT Show resolved Hide resolved

tomcur reviewed Sep 8, 2025

View reviewed changes

poly-cool/Cargo.toml Outdated Show resolved Hide resolved

jneem and others added 2 commits September 8, 2025 16:52

Update poly-cool/Cargo.toml

ca917dd

Co-authored-by: Tom Churchman <[email protected]>

Fix the license copyright header

5616d68

DJMcNab reviewed Sep 11, 2025

View reviewed changes

Put all copyright under Raph

f36e4e0

DJMcNab reviewed Sep 12, 2025

View reviewed changes

poly-cool/LICENSE-MIT Outdated Show resolved Hide resolved

polycool/Cargo.toml Show resolved Hide resolved

Try again with the copyright

2bfde2b

DJMcNab reviewed Sep 12, 2025

View reviewed changes

dominikh reviewed Sep 15, 2025

View reviewed changes

polycool/src/poly_dyn.rs Show resolved Hide resolved

tomcur reviewed Sep 15, 2025

View reviewed changes

dominikh reviewed Sep 16, 2025

View reviewed changes

polycool/src/poly_dyn.rs Show resolved Hide resolved

jneem added 2 commits September 15, 2025 21:30

Review comments

a1c2c1a

Rename magnitude

7c34318

dominikh reviewed Sep 16, 2025

View reviewed changes

polycool/src/poly_dyn.rs Show resolved Hide resolved

jneem added 2 commits September 16, 2025 10:15

Special-case quadratic as well

bc6bf58

Filter the root ranges

6a7ce0f

dominikh reviewed Sep 23, 2025

View reviewed changes

poly-cool/src/cubic.rs Outdated Show resolved Hide resolved

jneem added 2 commits September 22, 2025 21:58

Avoid NaNs in the Newton iteration

4d68c58

Update the comment

c5eda11

dominikh approved these changes Sep 23, 2025

View reviewed changes

Rename to polycool

6fe6727

jneem force-pushed the bring-in-poly-cool branch from aeda970 to 6fe6727 Compare October 9, 2025 03:04

jneem added this pull request to the merge queue Oct 18, 2025

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 18, 2025

Fix doc typo

7485765

jneem added this pull request to the merge queue Oct 18, 2025

Merged via the queue into linebender:main with commit 0786080 Oct 18, 2025
15 checks passed

jneem deleted the bring-in-poly-cool branch October 18, 2025 22:15

jneem mentioned this pull request Oct 19, 2025

Release polycool-0.4.0 #520

Merged

Bring poly-cool into the kurbo repo #502

Bring poly-cool into the kurbo repo #502

Uh oh!

Conversation

jneem commented Sep 6, 2025

Uh oh!

dfrg commented Sep 8, 2025

Uh oh!

jneem commented Sep 8, 2025

Uh oh!

Uh oh!

tomcur left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

DJMcNab Sep 11, 2025

Choose a reason for hiding this comment

Uh oh!

jneem Sep 12, 2025

Choose a reason for hiding this comment

Uh oh!

DJMcNab Sep 12, 2025

Choose a reason for hiding this comment

Uh oh!

jneem Sep 12, 2025

Choose a reason for hiding this comment

Uh oh!

xStrom commented Sep 11, 2025

Uh oh!

DJMcNab left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

DJMcNab left a comment

Choose a reason for hiding this comment

Uh oh!

jneem commented Sep 12, 2025

Uh oh!

Uh oh!

tomcur left a comment

Choose a reason for hiding this comment

Uh oh!

tomcur Sep 15, 2025

Choose a reason for hiding this comment

Uh oh!

jneem Sep 16, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dominikh left a comment

Choose a reason for hiding this comment

Uh oh!

jneem commented Sep 24, 2025

Uh oh!

DJMcNab commented Sep 24, 2025

Uh oh!

nicoburns commented Sep 24, 2025

Uh oh!

jneem commented Oct 18, 2025

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants