Make nested type returned by coalesce UDF all nullable#232
Merged
ljfgem merged 1 commit intolinkedin:masterfrom Feb 17, 2022
Merged
Conversation
(cherry picked from commit 77be9ea)
Collaborator
|
Thanks @rzhang10! Kicked off the i-tests. |
Member
Author
I agree that in coral-schema we haven't got such a test case, but I think the tests in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We should return all nested type as nullable since Hive types are all nullable by default.
We should also enhance the unit tests to do equality check using
getFullTypeString, which includes the information of nullability of the type.