Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@dadjeibaah
Copy link
Contributor

No description provided.

Copy link
Member

@siggy siggy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@adleong adleong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1️⃣3️⃣3️⃣

Copy link
Contributor

@hawkw hawkw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've commented on a couple of things I'd like changed, but would be okay with merging this as-is.

CHANGES.md Outdated
:rotating_light: Bugfix extravanganza alert! :rotating_light:

This release is an exciting one! We received a lot of contributions from our awesome Linkerd community. Special thanks
to @sgrankin and @carloszuluaga just to name a few. Checkout our recent blog post for the full list of everyone that contributed
Copy link
Contributor

@hawkw hawkw Dec 1, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • can we add a comma after "carloszuluaga" here? like "Special thanks to @sgrankin and @carloszuluaga, just to name a few."
  • can we turn the GitHub usernames into Markdown links?
  • once the blog post is live, can this link to it?

CHANGES.md Outdated
This release is an exciting one! We received a lot of contributions from our awesome Linkerd community. Special thanks
to @sgrankin and @carloszuluaga just to name a few. Checkout our recent blog post for the full list of everyone that contributed
to release 1.3.3.
* Fix a bug where Namerd using `io.l5d.etcd` as a dtab store returns a 500 HTTP Response when listing DTabs. (#1702)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we turn the PR issue numbers into Markdown links to those PRs?

@dadjeibaah dadjeibaah merged commit 9c47a74 into master Dec 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants