-
Notifications
You must be signed in to change notification settings - Fork 504
PR for 1.3.3 release #1720
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR for 1.3.3 release #1720
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1️⃣3️⃣3️⃣
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've commented on a couple of things I'd like changed, but would be okay with merging this as-is.
CHANGES.md
Outdated
| :rotating_light: Bugfix extravanganza alert! :rotating_light: | ||
|
|
||
| This release is an exciting one! We received a lot of contributions from our awesome Linkerd community. Special thanks | ||
| to @sgrankin and @carloszuluaga just to name a few. Checkout our recent blog post for the full list of everyone that contributed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- can we add a comma after "carloszuluaga" here? like "Special thanks to @sgrankin and @carloszuluaga, just to name a few."
- can we turn the GitHub usernames into Markdown links?
- once the blog post is live, can this link to it?
CHANGES.md
Outdated
| This release is an exciting one! We received a lot of contributions from our awesome Linkerd community. Special thanks | ||
| to @sgrankin and @carloszuluaga just to name a few. Checkout our recent blog post for the full list of everyone that contributed | ||
| to release 1.3.3. | ||
| * Fix a bug where Namerd using `io.l5d.etcd` as a dtab store returns a 500 HTTP Response when listing DTabs. (#1702) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we turn the PR issue numbers into Markdown links to those PRs?
No description provided.