fix(proxy-identity): use execve call on Linux to start the proxy #14307
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Zahari Dichev <[email protected]>
e48efa4 to
82aa8f6
Compare
adleong
approved these changes
Aug 1, 2025
olix0r
approved these changes
Aug 1, 2025
olix0r
pushed a commit
that referenced
this pull request
Aug 11, 2025
In a recent change #14307 we split the proxy running logic in the identity wrapper. It turns out that _unix suffixes are not ignored for windows builds. Therefore, we add a build tag to the file to ignore it for windows specific builds. For context: golang/go#51572 Signed-off-by: Zahari Dichev [email protected]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A recent change (#14126) altered the semantics of running the proxy from the identity wrapper. This has introduced regression in behavior on Linux systems. This PR reverts the logic on Unix to use
execve. This way we useos/execonly on Windows systems.Further investigation into Windows behavior will be carried out but for now we aim to revert back to the behavior we had on Unix prior to #14126