Upgrade to dep 0.5.0, go 1.10.3 #1479
Conversation
Signed-off-by: Kevin Lingerfelt <[email protected]>
Signed-off-by: Kevin Lingerfelt <[email protected]>
bin/dep
Outdated
| if [ "$version" != "$depversion" ]; then | ||
| rm "$depbin" | ||
| fi | ||
| fi |
There was a problem hiding this comment.
I think you could probably do this more easily--without relying on the output formatting of dep, for instance--by storing the $depversion in the $depbin (i think we do this for protoc in the api repo, for instance). I.e., if the version is encoded in the file name, there's no reason to discover what version the local file is.
There was a problem hiding this comment.
Ahh, that's a great point -- thanks. Will do.
bin/dep
Outdated
| depurl="${dep_base_url}dep-${os}-amd64${exe}" | ||
|
|
||
| if [ -f "$depbin" ]; then | ||
| version=$($depbin version | grep "^ version" | awk '{print $3}' | awk -F '-' '{print $1}') |
There was a problem hiding this comment.
also, code golf note:
grep "^ version" | awk '{print $3}' | ...
is better expressed as
awk '$1 ~ /^version$/ { print $3 }' | ...
Signed-off-by: Kevin Lingerfelt <[email protected]>
| echo Actual digest of $depbin does not match expected digest. | ||
| curl -L --silent --fail -o depbin "$depurl" | ||
| sha=$(curl -L --silent --fail "${depurl}.sha256" | awk '{ print $1 }') | ||
| (echo "$sha *depbin" | shasum -c -a 256 -p -s -) || { |
There was a problem hiding this comment.
should this be $depbin or perhaps it doesn't matter?
There was a problem hiding this comment.
It can't be $depbin since $depbin is now an absolute path, and that won't work here in the tmp dir. So instead I'm using the filename "depbin" everywhere in tmp.
This branch updates
bin/depto install dep v0.5.0 which was recently released. The new release includes golang/dep#1912, which substantially speeds up re-runningbin/dep ensure.I'm also upgrading the repo from go 1.10.2 to 1.10.3 as part of this change. And I've modified the
bin/depscript to pull checksums from the github release, so that we don't have to hardcode them in that script.