This repository was archived by the owner on Sep 16, 2019. It is now read-only.
implement pagination for aws rrs and lb #34
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linki
reviewed
Jan 3, 2017
pkg/aws/client.go
Outdated
| break | ||
| } | ||
|
|
||
| records = append(records, rsp.ResourceRecordSets...) |
Owner
There was a problem hiding this comment.
i think you can use this helper method to do the pagination.
linki
reviewed
Jan 3, 2017
pkg/aws/elb.go
Outdated
| CanonicalZoneID string | ||
| } | ||
|
|
||
| //LoadBalancerExtractor is a func type which is extract Classic and Application Loadbalancer |
Owner
There was a problem hiding this comment.
typo: which is extract => which extracts maybe? also explain the use case (e.g. extract from what)
linki
reviewed
Jan 3, 2017
pkg/aws/elb.go
Outdated
| }) | ||
| } | ||
|
|
||
| if aws.StringValue(resp.NextMarker) == "" { |
Owner
There was a problem hiding this comment.
this pagination helper could get rid of the manual marker stuff https://godoc.org/github.com/aws/aws-sdk-go/service/elb#ELB.DescribeLoadBalancersPages
linki
reviewed
Jan 3, 2017
pkg/aws/elb.go
Outdated
| if aws.StringValue(resp.NextMarker) == "" { | ||
| break | ||
| } | ||
| params.SetMarker(aws.StringValue(resp.NextMarker)) |
Owner
There was a problem hiding this comment.
linki
reviewed
Jan 3, 2017
pkg/aws/elb.go
Outdated
| } | ||
|
|
||
| return result, nil | ||
|
|
Contributor
Author
|
@linki thanks for the review, added the changes to use aws-sdk to implement pagination |
Owner
|
👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.