fix(jsonldgen): use correct ContextGenerator field #2621
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instantiation of ContextGenerator is passing a field that doesn't exist: "metadata". The right one appears to be "emit_metadata". Fixes #2620 Signed-off-by: Silvano Cirujano Cuesta <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2621 +/- ##
=======================================
Coverage 81.14% 81.14%
=======================================
Files 121 121
Lines 13552 13552
Branches 3801 3801
=======================================
Hits 10997 10997
- Misses 1923 1924 +1
+ Partials 632 631 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
I have some experience with JSON-LD from my past work ex, so happy to review these |
amc-corey-cox
approved these changes
Apr 23, 2025
There was a problem hiding this comment.
This looks right to me. I'll give @sujaypatil96 a bit to weigh in and then merge.
|
Ah, I see. You need this for the other PR and it is really very simple. I'm merging it now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instantiation of ContextGenerator is passing a field that doesn't exist:
metadata. The right one appears to beemit_metadata.The issue does not have any observable effect, because the value being passed to
metadatais hard-coded toFalseand the default of the correct fieldemit_metadatais alsoFalse. It is nevertheless an error that should get fixed or may otherwise bite us in the future.Fixes #2620