Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@dalito
Copy link
Member

@dalito dalito commented May 18, 2025

The first commit fixes the template for enums in subsets. Then the linter pointed out other problems in the template files:

  • a missing closing tag for the span-tags for marking deprecated elements (fixed in 2nd commit)
  • some (purely cosmetic) white space issues (fixed in 3rd commit)

Closes #2708

@codecov
Copy link

codecov bot commented May 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.95%. Comparing base (c4a343e) to head (fa0aea6).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2709   +/-   ##
=======================================
  Coverage   82.95%   82.95%           
=======================================
  Files         127      127           
  Lines       13856    13856           
  Branches     3863     3863           
=======================================
  Hits        11494    11494           
  Misses       1722     1722           
  Partials      640      640           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dalito dalito requested a review from sujaypatil96 May 18, 2025 19:38
@@ -1,4 +1,4 @@
# Type: {{ gen.name(element) }} {% if element.deprecated %} <span style="color: red;"><strong> (DEPRECATED) </strong> {% endif %}
# Type: {{ gen.name(element) }} {% if element.deprecated %} <span style="color: red;"><strong></span> (DEPRECATED) </strong> {% endif %}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

</span> is in the wrong place here

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Upps. Fixed.

@dalito dalito force-pushed the issue2708-gen-doc-template-fixes branch from 4eac1ff to ce72352 Compare May 20, 2025 17:01
@dalito dalito force-pushed the issue2708-gen-doc-template-fixes branch from ce72352 to 097a504 Compare June 3, 2025 15:57
@dalito dalito force-pushed the issue2708-gen-doc-template-fixes branch from 097a504 to fa0aea6 Compare June 3, 2025 20:08
@dalito dalito merged commit d208d54 into linkml:main Jun 3, 2025
25 checks passed
@dalito dalito deleted the issue2708-gen-doc-template-fixes branch June 3, 2025 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

gen-doc: Broken Enums table in Subset documentation

2 participants