OnePerClass linter rules for identifier and key attributes
#2921
Conversation
| Each attribute of this class represents a rule that can be enabled and possibly | ||
| configured by a configuration file. | ||
| attributes: | ||
| canonical_prefixes: |
There was a problem hiding this comment.
I put these in alphabetical order, hence the large diff in this and the generated file.
| validator = validator_cls(meta_json_schema, format_checker=validator_cls.FORMAT_CHECKER) | ||
| return validator |
There was a problem hiding this comment.
No need to create a variable if you return it immediately.
| class OnePerClass(LinterRule): | ||
| """Ensures that there is only one slot with the specified attribute per class.""" |
There was a problem hiding this comment.
Both checks are very similar so can create a more generic function to test.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2921 +/- ##
==========================================
+ Coverage 80.41% 83.82% +3.41%
==========================================
Files 140 140
Lines 15588 15611 +23
Branches 3167 3171 +4
==========================================
+ Hits 12535 13086 +551
+ Misses 2399 1833 -566
- Partials 654 692 +38 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
a9d3dc5 to
d49ef03
Compare
|
LMK if there is extra documentation or more comments that I can add to the tests to make it clearer how I'm generating the schemas. It makes perfect sense when you're writing the code but isn't always easy to decode when reading it. |
88a233a to
55b7a7e
Compare
| - id_slot_false | ||
| - key_slot_false | ||
| This allows the testing of a large number of combinations without having to generate them all manually. |
There was a problem hiding this comment.
To help grasp the pytest trick you could be explicit: "This and the stacked parametrize decorators allow testing of all combinations (2**6=64) ..."
Adding linter rules to enforce rules that ensure that
identifierandkeyonly appear once per class