[email protected]: Improve code readability #12338
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rename some variables Rename appList.js > workspace.js
move js/misc/state.js to [email protected] folder as it not used (and unlikely to be used) anywhere else.
|
@mtwebster Sorry, I didn't update this PR to reflect the changes in commit 3e1fca6 This means that line needs to change toas the method name was changed in this PR. Shall I open a new PR for this? Edit: created new PR #12521 |
|
Ah cool thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename some variables
Rename appList.js > workspace.js
Reorder settings-schema.json to match dialog window
This doesn't change any code functioning.
Edit: move state.js to applet folder.