Add support for Lenovo Yoga 9 14IAP7 #768
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
looks like my devious plan worked then! :) Merged, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't think this is complete yet, but since just creating issues is discouraged, I thought I'd get started and then finish the PR according to the changes requests. This is trying to add support for the Wacom HID 52C2 in the Lenovo Yoga 9 14IAP7. I don't think
sysinfo.shsucceeded in creating a .tablet file (at least I couldn't find one), so I tried adapting a similar one, and it seems to at least get recognized bylibwacom-list-local-devicesnow. But I wasn't sure about all values and how to adapt them, I tried following the "Adding a new device" guide.One thing I'm not sure how to handle is this device shows a "Finger" and "Pen" device, are these supposed to go in the same file or is the "Finger" device not meant to be in this repo any way? Also, the initial reason why I stumbled upon here is that one of the buttons on my stylus (Lenovo Precision Pen 2) randomly had a different action assigned, and now I have no idea how to reconfigure that, not sure if this will help. I saw some .tablet files have a styli field, but I couldn't find out what values I'd have to add in there.
Relevant descriptor issues: