Fix error in clean_svg.py and allow it to run on .tablet files
#782
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If nargs=1 the result is a tuple but that's not really necessary here.
Fixes: 2752276 ("tools/clean_svg.py: fix to work with Python3")
|
Thank you for the quick fix! 👍 |
If the svg file passed in is a .tablet file, extract the layout and tablet name from there. This allows us to run the tool on the existing tablet files to check for any differences. Add this into the CI so we ensure that script doesn't crash on our SVG files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the crasher reported by @Deevad in #777 (comment)