Async #115
Merged
Async #115
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous fix attempted to protect StepCounters map access with a mutex, but the mutex was being copied by value when JobContext was copied in executeJobRepeatLoopAsync. This created separate mutex instances for each goroutine, breaking synchronization. Changes: - Changed countersMu from sync.Mutex to *sync.Mutex in JobContext - Initialize countersMu pointer in all JobContext creation sites - Update all test files to initialize countersMu properly This ensures all goroutines share the same mutex instance, providing proper synchronization for concurrent StepCounters map access. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
The mutex protecting overallSuccess in executeJobRepeatLoopAsync was unnecessary. Using atomic.Bool is more efficient and cleaner for simple boolean flag synchronization. Changes: - Replace var mu sync.Mutex with atomic.Bool - Use overallSuccess.Store(false) instead of mutex-protected write - Use overallSuccess.Load() for final return value 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Code Metrics Report
Details | | main (c2a21f3) | #115 (4d12dc2) | +/- |
|---------------------|----------------|----------------|-------|
+ | Coverage | 47.7% | 47.7% | +0.0% |
| Files | 52 | 52 | 0 |
| Lines | 5226 | 5224 | -2 |
+ | Covered | 2496 | 2497 | +1 |
+ | Code to Test Ratio | 1:1.1 | 1:1.1 | +0.0 |
| Code | 10521 | 10524 | +3 |
+ | Test | 11651 | 11657 | +6 |
+ | Test Execution Time | 59s | 56s | -3s |Code coverage of files in pull request scope (71.2% → 71.7%)
Reported by octocov |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.