Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Comments

Virtual kubelet: switch to the v1 endpointslices API#1419

Merged
adamjensenbot merged 2 commits intoliqotech:masterfrom
giorio94:mio/epslicev1
Sep 27, 2022
Merged

Virtual kubelet: switch to the v1 endpointslices API#1419
adamjensenbot merged 2 commits intoliqotech:masterfrom
giorio94:mio/epslicev1

Conversation

@giorio94
Copy link
Member

@giorio94 giorio94 commented Sep 8, 2022

Description

This PR modifies the virtual kubelet to leverage the v1 endpointslice API, which has been introduced in kubernetes v1.21, and it is the only one present in v1.25. This is required to support the latest version of kubernetes, although dropping the support for older v1.19 and 1.20.

Additionally, it updates the version of envtest from v1.19 to v1.25, and fixes a set of context-related problems which caused the tests not to complete correctly with the new version of envtest.

Fixes #(issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also note any relevant details for your test configuration.

  • Existing tests
  • Manual testing on k8s v1.25

@adamjensenbot
Copy link
Collaborator

Hi @giorio94. Thanks for your PR!

I am @adamjensenbot.
You can interact with me issuing a slash command in the first line of a comment.
Currently, I understand the following commands:

  • /rebase: Rebase this PR onto the master branch (You can add the option test=true to launch the tests
    when the rebase operation is completed)
  • /merge: Merge this PR into the master branch
  • /build Build Liqo components
  • /test Launch the E2E and Unit tests
  • /hold, /unhold Add/remove the hold label to prevent merging with /merge

Make sure this PR appears in the liqo changelog, adding one of the following labels:

  • kind/breaking: 💥 Breaking Change
  • kind/feature: 🚀 New Feature
  • kind/bug: 🐛 Bug Fix
  • kind/cleanup: 🧹 Code Refactoring
  • kind/docs: 📝 Documentation

@giorio94
Copy link
Member Author

giorio94 commented Sep 8, 2022

/test

@giorio94 giorio94 changed the title Virtual kubelet: switch to the v1endpointslices API Virtual kubelet: switch to the v1 endpointslices API Sep 8, 2022
@giorio94 giorio94 force-pushed the mio/epslicev1 branch 2 times, most recently from 2d0e15e to 9e46c6c Compare September 9, 2022 09:16
@giorio94
Copy link
Member Author

giorio94 commented Sep 9, 2022

/test

@giorio94 giorio94 force-pushed the mio/epslicev1 branch 2 times, most recently from 8ab0cc4 to 809f710 Compare September 9, 2022 15:52
@giorio94
Copy link
Member Author

giorio94 commented Sep 9, 2022

/test

@giorio94
Copy link
Member Author

giorio94 commented Sep 9, 2022

/test

@giorio94
Copy link
Member Author

/rebase test=true

@giorio94
Copy link
Member Author

/rebase test=true

@giorio94
Copy link
Member Author

/rebase test=true

@giorio94 giorio94 requested a review from aleoli September 27, 2022 07:08
@giorio94 giorio94 marked this pull request as ready for review September 27, 2022 07:08
@giorio94
Copy link
Member Author

/merge

@adamjensenbot adamjensenbot added the merge-requested Request bot merging (automatically managed) label Sep 27, 2022
@adamjensenbot adamjensenbot merged commit b7b5541 into liqotech:master Sep 27, 2022
@adamjensenbot adamjensenbot removed the merge-requested Request bot merging (automatically managed) label Sep 27, 2022
@giorio94 giorio94 deleted the mio/epslicev1 branch October 17, 2022 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants