Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Comments

liqoctl install: support k3d through k3s provider#1574

Merged
adamjensenbot merged 1 commit intoliqotech:masterfrom
giorio94:mio/liqoctl-install-k3d-support
Dec 2, 2022
Merged

liqoctl install: support k3d through k3s provider#1574
adamjensenbot merged 1 commit intoliqotech:masterfrom
giorio94:mio/liqoctl-install-k3d-support

Conversation

@giorio94
Copy link
Member

@giorio94 giorio94 commented Dec 2, 2022

Description

This PR introduces a minor modification in liqoctl install to support the installation of liqo on k3s clusters created through k3d.

Fixes #1090

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also note any relevant details for your test configuration.

  • Manually, with two k3d clusters
  • Existing tests

@giorio94
Copy link
Member Author

giorio94 commented Dec 2, 2022

/test

@adamjensenbot
Copy link
Collaborator

Hi @giorio94. Thanks for your PR!

I am @adamjensenbot.
You can interact with me issuing a slash command in the first line of a comment.
Currently, I understand the following commands:

  • /rebase: Rebase this PR onto the master branch (You can add the option test=true to launch the tests
    when the rebase operation is completed)
  • /merge: Merge this PR into the master branch
  • /build Build Liqo components
  • /test Launch the E2E and Unit tests
  • /hold, /unhold Add/remove the hold label to prevent merging with /merge

Make sure this PR appears in the liqo changelog, adding one of the following labels:

  • kind/breaking: 💥 Breaking Change
  • kind/feature: 🚀 New Feature
  • kind/bug: 🐛 Bug Fix
  • kind/cleanup: 🧹 Code Refactoring
  • kind/docs: 📝 Documentation

@giorio94
Copy link
Member Author

giorio94 commented Dec 2, 2022

/merge

@adamjensenbot adamjensenbot added the merge-requested Request bot merging (automatically managed) label Dec 2, 2022
@adamjensenbot adamjensenbot merged commit b81f776 into liqotech:master Dec 2, 2022
@adamjensenbot adamjensenbot removed the merge-requested Request bot merging (automatically managed) label Dec 2, 2022
@giorio94 giorio94 deleted the mio/liqoctl-install-k3d-support branch January 6, 2023 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Install Liqo on K3d

3 participants