Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Helm: Fix extraArgs #2288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 19, 2024
Merged

Helm: Fix extraArgs #2288

merged 1 commit into from
Jan 19, 2024

Conversation

@kariya-mitsuru
Copy link
Contributor

Description

ExtraArgs was not applied in the following two deployments and one cronjob, so fixed it so that it is applied correctly.

  • deployments/liqo/templates/liqo-metric-agent-deployment.yaml
  • deployments/liqo/templates/liqo-proxy-deployment.yaml
  • deployments/liqo/templates/liqo-telemetry-cronjob.yaml

@adamjensenbot
Copy link
Collaborator

Hi @kariya-mitsuru. Thanks for your PR!

I am @adamjensenbot.
You can interact with me issuing a slash command in the first line of a comment.
Currently, I understand the following commands:

  • /rebase: Rebase this PR onto the master branch (You can add the option test=true to launch the tests
    when the rebase operation is completed)
  • /merge: Merge this PR into the master branch
  • /build Build Liqo components
  • /test Launch the E2E and Unit tests
  • /hold, /unhold Add/remove the hold label to prevent merging with /merge

Make sure this PR appears in the liqo changelog, adding one of the following labels:

  • kind/breaking: 💥 Breaking Change
  • kind/feature: 🚀 New Feature
  • kind/bug: 🐛 Bug Fix
  • kind/cleanup: 🧹 Code Refactoring
  • kind/docs: 📝 Documentation

@cheina97
Copy link
Member

Hi @kariya-mitsuru, thanks for your contribution. In other components we use this syntax to add extraargs https://github.com/kariya-mitsuru/liqo/blob/a3748d493921bc07262461d7277a21fd5d9e633c/deployments/liqo/templates/liqo-crd-replicator-deployment.yaml#L39-L41.

Can you adapt your commit to our syntax or modify all the other components?

fra98
fra98 reviewed Jan 18, 2024
View reviewed changes
@fra98
Copy link
Member

fra98 commented Jan 18, 2024 •
edited
Loading

LGTM! 👍🏻 @kariya-mitsuru
Can you please squash all commits into one?

@kariya-mitsuru
Helm: Fix extraArgs
e95a162 
ExtraArgs was not applied in the following two deployments and one cronjob,
so fixed it so that it is applied correctly.

- deployments/liqo/templates/liqo-metric-agent-deployment.yaml
- deployments/liqo/templates/liqo-proxy-deployment.yaml
- deployments/liqo/templates/liqo-telemetry-cronjob.yaml
@fra98
Copy link
Member

fra98 commented Jan 19, 2024

/rebase test=true

@fra98 fra98 self-requested a review January 19, 2024 08:49
@fra98
Copy link
Member

fra98 commented Jan 19, 2024

/merge

@adamjensenbot adamjensenbot added the merge-requested Request bot merging (automatically managed) label Jan 19, 2024
@adamjensenbot adamjensenbot merged commit ca59802 into liqotech:master Jan 19, 2024
@adamjensenbot adamjensenbot removed the merge-requested Request bot merging (automatically managed) label Jan 19, 2024
@kariya-mitsuru kariya-mitsuru deleted the fix-extraArgs branch January 20, 2024 07:09
@fra98 fra98 added the kind/bug label Jan 30, 2024
@chenrui333 chenrui333 mentioned this pull request Mar 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fra98 fra98 fra98 approved these changes

Assignees

No one assigned

Labels

size/S

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kariya-mitsuru @adamjensenbot @cheina97 @fra98