Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@fra98
Copy link
Member

@fra98 fra98 commented Aug 22, 2024

Description

This PR fixes a bug causing providers in liqoctl installer to overwrite some flags between each other.

@adamjensenbot
Copy link
Collaborator

Hi @fra98. Thanks for your PR!

I am @adamjensenbot.
You can interact with me issuing a slash command in the first line of a comment.
Currently, I understand the following commands:

  • /rebase: Rebase this PR onto the master branch (You can add the option test=true to launch the tests
    when the rebase operation is completed)
  • /merge: Merge this PR into the master branch
  • /build Build Liqo components
  • /test Launch the E2E and Unit tests
  • /hold, /unhold Add/remove the hold label to prevent merging with /merge

Make sure this PR appears in the liqo changelog, adding one of the following labels:

  • kind/breaking: πŸ’₯ Breaking Change
  • kind/feature: πŸš€ New Feature
  • kind/bug: πŸ› Bug Fix
  • kind/cleanup: 🧹 Code Refactoring
  • kind/docs: πŸ“ Documentation

@fra98
Copy link
Member Author

fra98 commented Aug 22, 2024

/test

1 similar comment
@fra98
Copy link
Member Author

fra98 commented Aug 22, 2024

/test

@fra98 fra98 marked this pull request as ready for review August 23, 2024 10:13
@fra98 fra98 force-pushed the frt/fix-provider-opts branch from 2708442 to 919220a Compare August 23, 2024 13:07
@fra98 fra98 requested a review from aleoli August 27, 2024 13:14
@fra98
Copy link
Member Author

fra98 commented Aug 28, 2024

/rebase test=true

@adamjensenbot adamjensenbot force-pushed the frt/fix-provider-opts branch from 919220a to cf4e0bd Compare August 28, 2024 10:52
@fra98
Copy link
Member Author

fra98 commented Aug 28, 2024

/merge

@adamjensenbot adamjensenbot added the merge-requested Request bot merging (automatically managed) label Aug 28, 2024
@adamjensenbot adamjensenbot merged commit 3a6721c into liqotech:master Aug 28, 2024
@adamjensenbot adamjensenbot removed the merge-requested Request bot merging (automatically managed) label Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants