-
Notifications
You must be signed in to change notification settings - Fork 128
New liqoctl info command
#2718
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
New liqoctl info command
#2718
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @claudiolor. Thanks for your PR! I am @adamjensenbot.
Make sure this PR appears in the liqo changelog, adding one of the following labels:
|
2f5309d to
540e256
Compare
fra98
reviewed
Sep 11, 2024
fra98
approved these changes
Sep 12, 2024
7c20a46 to
c9e24cd
Compare
|
/test |
This patch introduces `liqoctl info`command to retrieve the status of the current Liqo instance, plus some brief info about the active peerings.
c9e24cd to
06eacd2
Compare
|
/test |
1 similar comment
|
/test |
|
/merge |
This was referenced Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With the new version of Liqo the liqoctl status command has been removed because of some issues with the mantainabilty of the command, indeed it used to get the info from multiple CR and as with the new version of Liqo, a major refactoring of the resources has been done and complete rework on it was necessary.
The status command was a good way to check the:
This PR introduces the new
liqoctl infocommand as a replacement for the status command. It not only shows the current status of the local Liqo instance, but provides some brief info about the active peerings.By default the output is presented in a human-readable form. However, to simplify automate retrieval of the data, via the
-ooption it is possible to format the output inJSONorYAMLand, via the--get field.subfieldargument, each field of the reports can be individually retrieved.E.g.
Get the output in YAML format
Get the podCIDR of the local Liqo instance:
This PR add the boilerplate for the
liqoctl info peer <CLUSTED_ID>command, which is still not implemented.How Has This Been Tested?
Test suite provided.