Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@claudiolor
Copy link
Contributor

Description

With the new version of Liqo the liqoctl status command has been removed because of some issues with the mantainabilty of the command, indeed it used to get the info from multiple CR and as with the new version of Liqo, a major refactoring of the resources has been done and complete rework on it was necessary.

The status command was a good way to check the:

  • Health of the installation
  • Current configuration
  • Status of the peerings

This PR introduces the new liqoctl info command as a replacement for the status command. It not only shows the current status of the local Liqo instance, but provides some brief info about the active peerings.
By default the output is presented in a human-readable form. However, to simplify automate retrieval of the data, via the -o option it is possible to format the output in JSON or YAML and, via the --get field.subfield argument, each field of the reports can be individually retrieved.

E.g.
Get the output in YAML format

liqoctl info -o json

Get the podCIDR of the local Liqo instance:

liqoctl info --get network.podcidr

This PR add the boilerplate for the liqoctl info peer <CLUSTED_ID> command, which is still not implemented.

How Has This Been Tested?

Test suite provided.

@adamjensenbot
Copy link
Collaborator

Hi @claudiolor. Thanks for your PR!

I am @adamjensenbot.
You can interact with me issuing a slash command in the first line of a comment.
Currently, I understand the following commands:

  • /rebase: Rebase this PR onto the master branch (You can add the option test=true to launch the tests
    when the rebase operation is completed)
  • /merge: Merge this PR into the master branch
  • /build Build Liqo components
  • /test Launch the E2E and Unit tests
  • /hold, /unhold Add/remove the hold label to prevent merging with /merge

Make sure this PR appears in the liqo changelog, adding one of the following labels:

  • kind/breaking: πŸ’₯ Breaking Change
  • kind/feature: πŸš€ New Feature
  • kind/bug: πŸ› Bug Fix
  • kind/cleanup: 🧹 Code Refactoring
  • kind/docs: πŸ“ Documentation

@claudiolor
Copy link
Contributor Author

/test

This patch introduces `liqoctl info`command to retrieve the status
of the current Liqo instance, plus some brief info about the
active peerings.
@claudiolor
Copy link
Contributor Author

/test

1 similar comment
@fra98
Copy link
Member

fra98 commented Sep 16, 2024

/test

@fra98
Copy link
Member

fra98 commented Sep 16, 2024

/merge

@adamjensenbot adamjensenbot added the merge-requested Request bot merging (automatically managed) label Sep 16, 2024
@adamjensenbot adamjensenbot merged commit 84a08ba into liqotech:master Sep 16, 2024
@adamjensenbot adamjensenbot removed the merge-requested Request bot merging (automatically managed) label Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants