Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@fra98
Copy link
Member

@fra98 fra98 commented Oct 2, 2024

Description

This PR fixes the liqoctl disconnect command in case of bidirectional peering.

@fra98 fra98 changed the title Fix liqoctl disconnect on bidirectional Fix liqoctl disconnect on bidirectional peering Oct 2, 2024
@adamjensenbot
Copy link
Collaborator

Hi @fra98. Thanks for your PR!

I am @adamjensenbot.
You can interact with me issuing a slash command in the first line of a comment.
Currently, I understand the following commands:

  • /rebase: Rebase this PR onto the master branch (You can add the option test=true to launch the tests
    when the rebase operation is completed)
  • /merge: Merge this PR into the master branch
  • /build Build Liqo components
  • /test Launch the E2E and Unit tests
  • /hold, /unhold Add/remove the hold label to prevent merging with /merge

Make sure this PR appears in the liqo changelog, adding one of the following labels:

  • kind/breaking: πŸ’₯ Breaking Change
  • kind/feature: πŸš€ New Feature
  • kind/bug: πŸ› Bug Fix
  • kind/cleanup: 🧹 Code Refactoring
  • kind/docs: πŸ“ Documentation

@fra98 fra98 requested a review from aleoli October 2, 2024 11:17
@fra98 fra98 added the kind/bug label Oct 3, 2024
@fra98
Copy link
Member Author

fra98 commented Oct 3, 2024

/rebase test=true

@adamjensenbot adamjensenbot force-pushed the frt/disconnect-bidirectional branch from e3761e8 to f7afc6f Compare October 3, 2024 11:16
@fra98
Copy link
Member Author

fra98 commented Oct 3, 2024

/merge

@adamjensenbot adamjensenbot added the merge-requested Request bot merging (automatically managed) label Oct 3, 2024
@adamjensenbot adamjensenbot merged commit 20d9d8f into liqotech:master Oct 3, 2024
13 checks passed
@adamjensenbot adamjensenbot removed the merge-requested Request bot merging (automatically managed) label Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants